Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 9695038: Android: Remove a few more printing sources. (Closed)

Created:
8 years, 9 months ago by Yaron
Modified:
8 years, 9 months ago
Reviewers:
Jay Civelli, Evan Stade
CC:
chromium-reviews, gone
Visibility:
Public.

Description

Android: Remove a few more printing sources. There were some places that we didn't catch with https://chromiumcodereview.appspot.com/9447086/ BUG=117407 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126907

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : better rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Yaron
estade: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc jcivelli: chrome/test/base/testing_browser_process.cc
8 years, 9 months ago (2012-03-13 11:53:10 UTC) #1
Jay Civelli
lgtm
8 years, 9 months ago (2012-03-13 16:06:59 UTC) #2
Evan Stade
lgtm
8 years, 9 months ago (2012-03-14 21:14:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9695038/1
8 years, 9 months ago (2012-03-14 23:29:43 UTC) #4
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc. While running patch -p1 --forward --force; patching file chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc ...
8 years, 9 months ago (2012-03-14 23:29:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9695038/1
8 years, 9 months ago (2012-03-15 10:51:12 UTC) #6
commit-bot: I haz the power
Try job failure for 9695038-1 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-15 11:18:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9695038/6003
8 years, 9 months ago (2012-03-15 11:57:03 UTC) #8
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 14:20:48 UTC) #9
Try job failure for 9695038-6003 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698