Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 9695029: Change the login flow for kiosk mode. (Closed)

Created:
8 years, 9 months ago by rkc
Modified:
8 years, 9 months ago
Reviewers:
tbarzic, sky
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Change the login flow for kiosk mode. Instead of showing the demo user UI, show the screensaver directly. On going active, the user gets dropped into a demo user session directly (see bug for details). Additionally removed the Lock Screen and Shutdown options from the wrench menu model for ChromeOS. tbarzic@ - main review sky@ - owners review for chrome/browser/ui/toolbar/wrench_menu_model_chromeos.cc R=tbarzic@chromium.org,sky@chromium.org BUG=chromium-os:26041, chromium-os:27543 TEST=Ran unit tests, tested with kiosk-mode flags and tested with giving an invalid screensaver to test the fallback flow. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126736

Patch Set 1 #

Patch Set 2 : style nits. #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc View 1 4 chunks +19 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver_unittest.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model_chromeos.cc View 1 2 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rkc
8 years, 9 months ago (2012-03-13 02:06:25 UTC) #1
tbarzic
On 2012/03/13 02:06:25, Rahul Chaturvedi wrote: lgtm
8 years, 9 months ago (2012-03-13 06:00:48 UTC) #2
sky
LGTM
8 years, 9 months ago (2012-03-13 16:00:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/9695029/3005
8 years, 9 months ago (2012-03-13 18:30:31 UTC) #4
commit-bot: I haz the power
Try job failure for 9695029-3005 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-13 20:59:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/9695029/3005
8 years, 9 months ago (2012-03-14 01:32:06 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-14 03:59:23 UTC) #7
Try job failure for 9695029-3005 (retry) on win_rel for steps "ui_tests,
browser_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698