Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 9695013: DOMStorageContextImpl that's implemented in terms of the new dom_storage classes. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/in_process_webkit/dom_storage_unittest.cc ('k') | webkit/dom_storage/dom_storage_area.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_message_filter.cc
===================================================================
--- content/browser/renderer_host/render_message_filter.cc (revision 127221)
+++ content/browser/renderer_host/render_message_filter.cc (working copy)
@@ -411,9 +411,21 @@
return;
}
+#ifdef ENABLE_NEW_DOM_STORAGE_BACKEND
+ // TODO(michaeln): Fix this.
+ // This is a bug in the existing impl, session storage is effectively
+ // leaked when created thru this code path (window.open()) since there
+ // is no balancing DeleteSessionStorage() for this Clone() call anywhere
+ // in the codebase. I'm replicating the bug for now.
*cloned_session_storage_namespace_id =
+ dom_storage_context_->LeakyCloneSessionStorage(
+ params.session_storage_namespace_id);
+#else
+ *cloned_session_storage_namespace_id =
dom_storage_context_->CloneSessionStorage(
params.session_storage_namespace_id);
+#endif
+
render_widget_helper_->CreateNewWindow(params,
peer_handle(),
route_id,
« no previous file with comments | « content/browser/in_process_webkit/dom_storage_unittest.cc ('k') | webkit/dom_storage/dom_storage_area.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698