content/browser/renderer_host/render_message_filter.cc - Issue 9695013: DOMStorageContextImpl that's implemented in terms of the new dom_storage classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 9695013: DOMStorageContextImpl that's implemented in terms of the new dom_storage classes. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/in_process_webkit/dom_storage_unittest.cc ('k') | webkit/dom_storage/dom_storage_area.h » ('j') | webkit/dom_storage/dom_storage_area.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_message_filter.cc

===================================================================

--- content/browser/renderer_host/render_message_filter.cc (revision 127221)

+++ content/browser/renderer_host/render_message_filter.cc (working copy)

@@ -411,9 +411,21 @@

return;

}

+#ifdef ENABLE_NEW_DOM_STORAGE_BACKEND

+ // TODO(michaeln): Fix this.

+ // This is a bug in the existing impl, session storage is effectively

+ // leaked when created thru this code path (window.open()) since there

+ // is no balancing DeleteSessionStorage() for this Clone() call anywhere

+ // in the codebase. I'm replicating the bug for now.

*cloned_session_storage_namespace_id =

+ dom_storage_context_->LeakyCloneSessionStorage(

+ params.session_storage_namespace_id);

+#else

+ *cloned_session_storage_namespace_id =

dom_storage_context_->CloneSessionStorage(

params.session_storage_namespace_id);

+#endif

render_widget_helper_->CreateNewWindow(params,

peer_handle(),

route_id,