Run google_apis_unittests on win bots.

Run google_apis_unittests on win bots.

BUG=257421
R=stip@chromium.org,joi@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=239265

[tfarina, 2013-11-30 16:53:28]

CQ change is here: https://codereview.chromium.org/96903006/

[Jói, 2013-12-02 10:07:18]

LGTM

On Sat, Nov 30, 2013 at 4:53 PM,  <tfarina@chromium.org> wrote:
> Reviewers: Jói, stip (OoO 11-25 - 11-29),
>
> Message:
> CQ change is here: https://codereview.chromium.org/96903006/
>
> Description:
> Run google_apis_unittests on win bots.
>
> BUG=257421
> R=stip@chromium.org,joi@chromium.org
>
> Please review this at https://codereview.chromium.org/96943003/
>
> SVN Base: https://chromium.googlesource.com/chromium/tools/build@master
>
> Affected files (+3, -0 lines):
>   M masters/master.chromium.win/master_gatekeeper_cfg.py
>   M masters/master.chromium.win/master_win_cfg.py
>
>
> Index: masters/master.chromium.win/master_gatekeeper_cfg.py
> diff --git a/masters/master.chromium.win/master_gatekeeper_cfg.py
> b/masters/master.chromium.win/master_gatekeeper_cfg.py
> index
>
016c74c705a67853513d359fc79ca8d60c260635..cf32f7ddca0e03714e1171c033b19200a5a2cf78
> 100644
> --- a/masters/master.chromium.win/master_gatekeeper_cfg.py
> +++ b/masters/master.chromium.win/master_gatekeeper_cfg.py
> @@ -29,6 +29,7 @@ categories_steps = {
>      'crypto_unittests',
>      'device_unittests',
>      'events_unittests',
> +    'google_apis_unittests',
>      'installer_util_unittests',
>      'interactive_ui_tests',
>      'ipc_tests',
> Index: masters/master.chromium.win/master_win_cfg.py
> diff --git a/masters/master.chromium.win/master_win_cfg.py
> b/masters/master.chromium.win/master_win_cfg.py
> index
>
2eb56d08b6dbd78914c24233286f45bd8f0c60b1..e81bcf9adcc044d05f027a1220f4344298384988
> 100644
> --- a/masters/master.chromium.win/master_win_cfg.py
> +++ b/masters/master.chromium.win/master_win_cfg.py
> @@ -36,6 +36,7 @@ sharded_tests = [
>    'crypto_unittests',
>    'device_unittests',
>    'events_unittests',
> +  'google_apis_unittests',
>    'gpu_unittests',
>    'jingle_unittests',
>    'media_unittests',
> @@ -224,6 +225,7 @@ F('rel_x64_unit_1', win_tester().ChromiumFactory(
>        'content_browsertests',
>        'courgette_unittests',
>        'crypto_unittests',
> +      'google_apis_unittests',
>        'gpu_unittests',
>        'installer_util_unittests',
>        'interactive_ui_tests',
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[ghost stip (do not use), 2013-12-02 23:16:15]

add trybot coverage here as per https://chromiumcodereview.appspot.com/96903006/

https://chromiumcodereview.appspot.com/96943003/diff/1/masters/master.chromiu...
File masters/master.chromium.win/master_win_cfg.py (right):

https://chromiumcodereview.appspot.com/96943003/diff/1/masters/master.chromiu...
masters/master.chromium.win/master_win_cfg.py:228: 'google_apis_unittests',
also add to rel_unit_1, 2 or 3 depending on which is fastest

[tfarina, 2013-12-03 21:37:11]

https://chromiumcodereview.appspot.com/96943003/diff/1/masters/master.chromiu...
File masters/master.chromium.win/master_win_cfg.py (right):

https://chromiumcodereview.appspot.com/96943003/diff/1/masters/master.chromiu...
masters/master.chromium.win/master_win_cfg.py:228: 'google_apis_unittests',
On 2013/12/02 23:16:15, stip wrote:
> also add to rel_unit_1, 2 or 3 depending on which is fastest
added to rel_unit_3

[tfarina, 2013-12-05 11:00:56]

ping?

[ghost stip (do not use), 2013-12-05 19:13:14]

you still need the master.tryserver.chromium change here, just to add the test
to win_rel

[tfarina, 2013-12-05 22:01:42]

On 2013/12/05 19:13:14, stip wrote:
> you still need the master.tryserver.chromium change here, just to add the test
> to win_rel

Done.

[ghost stip (do not use), 2013-12-05 22:18:27]

https://codereview.chromium.org/96943003/diff/40001/masters/master.tryserver....
File masters/master.tryserver.chromium/master.cfg (right):

https://codereview.chromium.org/96943003/diff/40001/masters/master.tryserver....
masters/master.tryserver.chromium/master.cfg:758: 'google_apis_unittests',
I think you have to add them to tests= as well (line 745), but I'm checking with
M-A to confirm

[M-A Ruel, 2013-12-06 01:35:02]

https://codereview.chromium.org/96943003/diff/40001/masters/master.tryserver....
File masters/master.tryserver.chromium/master.cfg (right):

https://codereview.chromium.org/96943003/diff/40001/masters/master.tryserver....
masters/master.tryserver.chromium/master.cfg:758: 'google_apis_unittests',
On 2013/12/05 22:18:27, stip wrote:
> I think you have to add them to tests= as well (line 745), but I'm checking
with
> M-A to confirm

To be listed there, it has to have google_apis_unittests.isolate, as described
at
http://dev.chromium.org/developers/testing/isolated-testing/for-swes#TOC-Addi....

I don't see one in the tree so do not add it here.

[M-A Ruel, 2013-12-06 01:36:56]

https://codereview.chromium.org/96943003/diff/40001/masters/master.tryserver....
File masters/master.tryserver.chromium/master.cfg (right):

https://codereview.chromium.org/96943003/diff/40001/masters/master.tryserver....
masters/master.tryserver.chromium/master.cfg:705: 'googleurl_br',
This is where you want to add it.

[tfarina, 2013-12-06 21:06:40]

https://codereview.chromium.org/96943003/diff/40001/masters/master.tryserver....
File masters/master.tryserver.chromium/master.cfg (right):

https://codereview.chromium.org/96943003/diff/40001/masters/master.tryserver....
masters/master.tryserver.chromium/master.cfg:705: 'googleurl_br',
On 2013/12/06 01:36:57, M-A Ruel wrote:
> This is where you want to add it.

Done.

[M-A Ruel, 2013-12-06 21:13:47]

try server part lgtm

[ghost stip (do not use), 2013-12-06 21:42:55]

lgtm with one change

https://codereview.chromium.org/96943003/diff/60001/masters/master.tryserver....
File masters/master.tryserver.chromium/master.cfg (right):

https://codereview.chromium.org/96943003/diff/60001/masters/master.tryserver....
masters/master.tryserver.chromium/master.cfg:705: 'google_apis_unittests',
google_apis_unittests_br

[tfarina, 2013-12-06 22:06:29]

https://codereview.chromium.org/96943003/diff/60001/masters/master.tryserver....
File masters/master.tryserver.chromium/master.cfg (right):

https://codereview.chromium.org/96943003/diff/60001/masters/master.tryserver....
masters/master.tryserver.chromium/master.cfg:705: 'google_apis_unittests',
On 2013/12/06 21:42:55, stip wrote:
> google_apis_unittests_br

Done.

[commit-bot: I haz the power, 2013-12-06 22:10:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/96943003/80001

[commit-bot: I haz the power, 2013-12-06 22:11:15]

Change committed as 239265