Issue 9694041: Split up String.split to deal with normal separator and regexp separator separately.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9694041: Split up String.split to deal with normal separator and regexp separator separately. (Closed)

Created:
8 years, 9 months ago by Yang

Modified:
8 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Split up String.split to deal with normal separator and regexp separator separately. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11030

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	src/string.js	View		2 chunks	+7 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 9 months ago (2012-03-13 15:39:06 UTC) #2

LGTM

http://codereview.chromium.org/9694041/diff/1/src/string.js
File src/string.js (right):

http://codereview.chromium.org/9694041/diff/1/src/string.js#newcode1
src/string.js:1: // Copyright 2006-2009 the V8 project authors. All rights
reserved.
2012

Expand Messages | Collapse Messages