Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 9694038: OBSOLETE REVIEW. See http://codereview.chromium.org/10382149/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extension_list.js
===================================================================
--- chrome/browser/resources/extensions/extension_list.js (revision 136836)
+++ chrome/browser/resources/extensions/extension_list.js (working copy)
@@ -48,8 +48,7 @@
*/
showExtensionNodes_: function() {
// Iterate over the extension data and add each item to the list.
- var list = this;
- this.data_.extensions.forEach(this.createNode_.bind(this));
+ this.data_.extensions.forEach(this.createNode_, this);
if (this.data_.extensions.length == 0)
this.classList.add('empty-extension-list');
@@ -72,7 +71,7 @@
if (!extension.enabled || extension.terminated)
node.classList.add('inactive-extension');
- if (!extension.mayDisable)
+ if (!extension.mayModifyStatus)
node.classList.add('may-not-disable');
var item = node.querySelector('.extension-list-item');
@@ -156,13 +155,17 @@
reload.hidden = false;
}
+ // Disable optional controls if they cannot be used.
+ node.querySelector('.optional-controls').hidden =
+ !extension.mayModifyUsage;
+
if (!extension.terminated) {
// The 'Enabled' checkbox.
var enable = node.querySelector('.enable-checkbox');
enable.hidden = false;
- enable.querySelector('input').disabled = !extension.mayDisable;
+ enable.querySelector('input').disabled = !extension.mayModifyStatus;
- if (extension.mayDisable) {
+ if (extension.mayModifyStatus) {
enable.addEventListener('click', function(e) {
chrome.send('extensionSettingsEnable',
[extension.id, e.target.checked ? 'true' : 'false']);
@@ -202,7 +205,7 @@
}
// Then the 'managed, cannot uninstall/disable' message.
- if (!extension.mayDisable)
+ if (!extension.mayModifyStatus)
node.querySelector('.managed-message').hidden = false;
// Then active views.

Powered by Google App Engine
This is Rietveld 408576698