Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6819)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 9694038: OBSOLETE REVIEW. See http://codereview.chromium.org/10382149/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | chrome/browser/extensions/extension_context_menu_browsertest.cc » ('j') | chrome/browser/extensions/extension_management_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer.cc
===================================================================
--- chrome/browser/extensions/crx_installer.cc (revision 136836)
+++ chrome/browser/extensions/crx_installer.cc (working copy)
@@ -348,12 +348,10 @@
return;
}
- if (!frontend_weak_->extension_prefs()->IsExtensionAllowedByPolicy(
- extension_->id(), install_source_)) {
- ReportFailureFromUIThread(l10n_util::GetStringFUTF16(
- IDS_EXTENSION_CANT_INSTALL_POLICY_BLACKLIST,
- UTF8ToUTF16(extension_->name()),
- UTF8ToUTF16(extension_->id())));
+ string16 error;
+ if (!frontend_weak_->extension_management_policy()->UserMayInstall(
Aaron Boodman 2012/05/17 22:41:06 ExtensionSystem should own ManagementPolicy, not E
+ extension_->id(), install_source_, extension_->name(), &error)) {
+ ReportFailureFromUIThread(error);
return;
}
« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | chrome/browser/extensions/extension_context_menu_browsertest.cc » ('j') | chrome/browser/extensions/extension_management_api.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698