OBSOLETE REVIEW. See http://codereview.chromium.org/10382149/

chrome/browser/extensions/extension_management_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_management_api.h"
 
 #include <map>
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 40 matching lines @@
 ExtensionService* AsyncExtensionManagementFunction::service() {
   return profile()->GetExtensionService();
 }
 
 static DictionaryValue* CreateExtensionInfo(const Extension& extension,
                                             ExtensionService* service) {
   DictionaryValue* info = new DictionaryValue();
   bool enabled = service->IsExtensionEnabled(extension.id());
   extension.GetBasicInfo(enabled, info);
 
+  info->SetBoolean(keys::kMayDisableKey, service->

[Aaron Boodman, 2012/05/17 22:41:06]

What's the need for this?

[Aaron Boodman, 2012/05/17 22:41:06]

Wrapping: param lines should all start at same column. Also, it's weird looking
to wrap after the arrow.

[Pam (message me for reviews), 2012/05/18 20:15:15]

It's part of the ExtensionInfo returned by the API. It was originally set here,
then it moved into GetBasicInfo(), and now it has to move back out since the
extension doesn't know about the ManagementPolicy.

+      extension_management_policy()->UserMayModifyStatus(&extension, NULL));
+
   info->SetBoolean(keys::kIsAppKey, extension.is_app());
 
   if (!enabled) {
     bool permissions_escalated = service->extension_prefs()->
         DidExtensionEscalatePermissions(extension.id());
     const char* reason = permissions_escalated ?
         keys::kDisabledReasonPermissionsIncrease : keys::kDisabledReasonUnknown;
     info->SetString(keys::kDisabledReasonKey, reason);
   }
 
@@ skipping 287 matching lines @@
   EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &extension_id_));
   EXTENSION_FUNCTION_VALIDATE(args_->GetBoolean(1, &enable));
 
   const Extension* extension = service()->GetExtensionById(extension_id_, true);
   if (!extension) {
     error_ = ExtensionErrorUtils::FormatErrorMessage(
         keys::kNoExtensionError, extension_id_);
     return false;
   }
 
-  if (!Extension::UserMayDisable(extension->location())) {
-    error_ = ExtensionErrorUtils::FormatErrorMessage(
-        keys::kUserCantDisableError, extension_id_);
+  if (!service()->extension_management_policy()->
+      UserMayModifyStatus(extension, NULL)) {
+    if (enable) {
+      error_ = ExtensionErrorUtils::FormatErrorMessage(
+          keys::kUserCantModifyError, extension_id_);

[Aaron Boodman, 2012/05/17 22:41:06]

Can we just have a generic kUserCantDoAnything error? The string values aren't
part of our API contract, it's OK to change them.

[Pam (message me for reviews), 2012/05/18 20:15:15]

Excellent, I'd love to consolidate them.

+    } else {
+      error_ = ExtensionErrorUtils::FormatErrorMessage(
+          keys::kUserCantDisableError, extension_id_);
+    }
     return false;
   }
 
   bool currently_enabled = service()->IsExtensionEnabled(extension_id_);
 
   if (!currently_enabled && enable) {
     ExtensionPrefs* prefs = service()->extension_prefs();
     if (prefs->DidExtensionEscalatePermissions(extension_id_)) {
       if (!user_gesture()) {
         error_ = keys::kGestureNeededForEscalationError;
@@ skipping 32 matching lines @@
 bool UninstallFunction::RunImpl() {
   std::string extension_id;
   EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &extension_id));
 
   if (!service()->GetExtensionById(extension_id, true)) {
     error_ = ExtensionErrorUtils::FormatErrorMessage(
         keys::kNoExtensionError, extension_id);
     return false;
   }
 
-  ExtensionPrefs* prefs = service()->extension_prefs();
-
-  if (!Extension::UserMayDisable(
-      prefs->GetInstalledExtensionInfo(extension_id)->extension_location)) {
+  const Extension* extension = service()->GetExtensionById(extension_id, true);
+  if (!service()->extension_management_policy()->
+      UserMayModifyStatus(extension, NULL)) {

[Aaron Boodman, 2012/05/17 22:41:06]

Wrap at open paren. You should also change extension_management_policy ->
management_policy, which will help here.

     error_ = ExtensionErrorUtils::FormatErrorMessage(
         keys::kUserCantDisableError, extension_id);
     return false;
   }
 
   service()->UninstallExtension(extension_id, false /* external_uninstall */,
                                 NULL);
   return true;
 }
 
@@ skipping 60 matching lines @@
     ExtensionService* service = profile->GetExtensionService();
     args.Append(CreateExtensionInfo(*extension, service));
   }
 
   std::string args_json;
   base::JSONWriter::Write(&args, &args_json);
 
   profile->GetExtensionEventRouter()->DispatchEventToRenderers(
       event_name, args_json, NULL, GURL());
 }