Issue 9694034: Fix PickleIterator::GetReadPointerAndAdvance() not to produce wild addresses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9694034: Fix PickleIterator::GetReadPointerAndAdvance() not to produce wild addresses (Closed)

Created:
8 years, 9 months ago by Alexander Potapenko

Modified:
8 years, 9 months ago

Reviewers:
willchan no longer on Chromium, jbates

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix PickleTest.GetReadPointerAndAdvance not to produce wild addresses while checking for overflows. BUG=117704 TBR=willchan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126413

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	base/pickle.cc	View		1 chunk	+2 lines, -6 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jbates

LGTM, thanks. https://chromiumcodereview.appspot.com/9694034/diff/1/base/pickle.cc File base/pickle.cc (right): https://chromiumcodereview.appspot.com/9694034/diff/1/base/pickle.cc#newcode48 base/pickle.cc:48: if (num_bytes < 0 || read_end_ptr_ - ...

8 years, 9 months ago (2012-03-13 16:52:44 UTC) #2

lgtm

Expand Messages | Collapse Messages