Issue 9694028: Add a Content API around TracingController.

Issue 9694028: Add a Content API around TracingController. (Closed)

Created:
8 years, 9 months ago by jam

Modified:
8 years, 9 months ago

Reviewers:
Jói

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, robertshield, jam, kkania

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add a Content API around TracingController. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126396

Patch Set 2 : fix linux #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+230 lines, -713 lines)			Patch
M	chrome/browser/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/automation/automation_provider.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/profiler_ui.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/tracing_ui.cc	View		4 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/test/base/tracing.cc	View		3 chunks	+7 lines, -4 lines	0 comments	Download
M	content/browser/browser_main_loop.cc	View		3 chunks	+7 lines, -3 lines	0 comments	Download
D	content/browser/trace_controller.h	View		1 chunk	+0 lines, -180 lines	0 comments	Download
D	content/browser/trace_controller.cc	View		1 chunk	+0 lines, -373 lines	0 comments	Download
A +	content/browser/trace_controller_impl.h	View	1	4 chunks	+22 lines, -91 lines	0 comments	Download
A +	content/browser/trace_controller_impl.cc	View		21 chunks	+42 lines, -44 lines	0 comments	Download
M	content/browser/trace_message_filter.cc	View		4 chunks	+8 lines, -7 lines	0 comments	Download
M	content/browser/trace_subscriber_stdio.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	content/browser/trace_subscriber_stdio.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	content/content_browser.gypi	View		2 chunks	+4 lines, -2 lines	0 comments	Download
A	content/public/browser/trace_controller.h	View		1 chunk	+86 lines, -0 lines	0 comments	Download
A	content/public/browser/trace_subscriber.h	View		1 chunk	+40 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jói

LGTM with a nit http://codereview.chromium.org/9694028/diff/7004/content/public/browser/trace_subscriber.h File content/public/browser/trace_subscriber.h (right): http://codereview.chromium.org/9694028/diff/7004/content/public/browser/trace_subscriber.h#newcode17 content/public/browser/trace_subscriber.h:17: class TraceSubscriber { Since this ...

8 years, 9 months ago (2012-03-13 10:13:51 UTC) #2

Jói

8 years, 9 months ago (2012-03-13 13:03:41 UTC) #3

LGTM

http://codereview.chromium.org/9694028/diff/7004/content/public/browser/trace...
File content/public/browser/trace_subscriber.h (right):

http://codereview.chromium.org/9694028/diff/7004/content/public/browser/trace...
content/public/browser/trace_subscriber.h:17: class TraceSubscriber {
On 2012/03/13 10:13:51, Jói wrote:
> Since this is in the Content API, shouldn't it be exported?  Then you could
get
> rid of the NON_EXPORTED_BASE declaration where TraceSubscriberStdio inherits
> from this.

Never mind, just realized this is pure virtual.

Expand Messages | Collapse Messages