ScopedPrinterInfoSetter on crash prone blocks.

ScopedPrinterInfoSetter sets printer related information to be available for breakpad. This CL inserts ScopedPrinterInfoSetter in places where Cloud print accesses printers and crash is possible.

BUG=108194
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127131

[Vitaly Buka (NO REVIEWS), 2012-03-13 23:00:09]

Please review this CL

[Albert Bodenhamer, 2012-03-13 23:57:39]

Please add a more detailed CL description.

https://chromiumcodereview.appspot.com/9693064/diff/1/chrome/service/cloud_pr...
File chrome/service/cloud_print/print_system_cups.cc (right):

https://chromiumcodereview.appspot.com/9693064/diff/1/chrome/service/cloud_pr...
chrome/service/cloud_print/print_system_cups.cc:243: delegate_(NULL),
why is this changed?

https://chromiumcodereview.appspot.com/9693064/diff/1/chrome/service/cloud_pr...
chrome/service/cloud_print/print_system_cups.cc:523:
child_process_logging::ScopedPrinterInfoSetter
prn_info(server_info->backend->GetPrinterDriverInfo());
80 chars

https://chromiumcodereview.appspot.com/9693064/diff/1/printing/backend/print_...
File printing/backend/print_backend_cups.cc (right):

https://chromiumcodereview.appspot.com/9693064/diff/1/printing/backend/print_...
printing/backend/print_backend_cups.cc:249: const char* info =
cupsGetOption(kCUPSPrinterMakeModelOpt, printer.num_options,
80 chars

https://chromiumcodereview.appspot.com/9693064/diff/6002/printing/backend/pri...
File printing/backend/print_backend_win.cc (right):

https://chromiumcodereview.appspot.com/9693064/diff/6002/printing/backend/pri...
printing/backend/print_backend_win.cc:180: std::string
PrintBackendWin::GetPrinterDriverInfo(const std::string& printer_name) {
80 chars

[Vitaly Buka (NO REVIEWS), 2012-03-14 00:11:20]

https://chromiumcodereview.appspot.com/9693064/diff/1/chrome/service/cloud_pr...
File chrome/service/cloud_print/print_system_cups.cc (right):

https://chromiumcodereview.appspot.com/9693064/diff/1/chrome/service/cloud_pr...
chrome/service/cloud_print/print_system_cups.cc:243: delegate_(NULL),
It was attempt to fix style, but still incorrectly.
Now it's fixed.
On 2012/03/13 23:57:39, Albert Bodenhamer wrote:
> why is this changed?

https://chromiumcodereview.appspot.com/9693064/diff/1/chrome/service/cloud_pr...
chrome/service/cloud_print/print_system_cups.cc:523:
child_process_logging::ScopedPrinterInfoSetter
prn_info(server_info->backend->GetPrinterDriverInfo());
On 2012/03/13 23:57:39, Albert Bodenhamer wrote:
> 80 chars

Done.

https://chromiumcodereview.appspot.com/9693064/diff/1/printing/backend/print_...
File printing/backend/print_backend_cups.cc (right):

https://chromiumcodereview.appspot.com/9693064/diff/1/printing/backend/print_...
printing/backend/print_backend_cups.cc:249: const char* info =
cupsGetOption(kCUPSPrinterMakeModelOpt, printer.num_options,
On 2012/03/13 23:57:39, Albert Bodenhamer wrote:
> 80 chars

Done.

https://chromiumcodereview.appspot.com/9693064/diff/6002/printing/backend/pri...
File printing/backend/print_backend_win.cc (right):

https://chromiumcodereview.appspot.com/9693064/diff/6002/printing/backend/pri...
printing/backend/print_backend_win.cc:180: std::string
PrintBackendWin::GetPrinterDriverInfo(const std::string& printer_name) {
On 2012/03/13 23:57:39, Albert Bodenhamer wrote:
> 80 chars

Done.

[Albert Bodenhamer, 2012-03-14 00:20:09]

lgtm

[commit-bot: I haz the power, 2012-03-15 09:06:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/9693064/7004

[commit-bot: I haz the power, 2012-03-15 09:25:25]

Try job failure for 9693064-7004 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-16 05:10:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/9693064/8007

[commit-bot: I haz the power, 2012-03-16 07:28:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/9693064/2015

[commit-bot: I haz the power, 2012-03-16 08:54:58]

Change committed as 127131