Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 9693045: WebKit support for EXT_occlusion_query. (Closed)

Created:
8 years, 9 months ago by reveman
Modified:
8 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

WebKit support for EXT_occlusion_query. BUG=117768 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126662

Patch Set 1 #

Patch Set 2 : style consistency fix #

Total comments: 1

Patch Set 3 : initialize GL object #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -0 lines) Patch
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 1 2 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nduca
LGTM but lets resolve the question of extension name for the "chromium fence." +apatrick for ...
8 years, 9 months ago (2012-03-13 17:48:15 UTC) #1
apatrick_chromium
https://chromiumcodereview.appspot.com/9693045/diff/8/webkit/gpu/webgraphicscontext3d_in_process_impl.cc File webkit/gpu/webgraphicscontext3d_in_process_impl.cc (right): https://chromiumcodereview.appspot.com/9693045/diff/8/webkit/gpu/webgraphicscontext3d_in_process_impl.cc#newcode1642 webkit/gpu/webgraphicscontext3d_in_process_impl.cc:1642: glGenQueriesARB(1, &o); If glGenQueriesARB fails, o will be uninitialized.
8 years, 9 months ago (2012-03-13 18:21:27 UTC) #2
google-reveman
On Tue, Mar 13, 2012 at 2:21 PM, <apatrick@chromium.org> wrote: > > https://chromiumcodereview.appspot.com/9693045/diff/8/webkit/gpu/webgraphicscontext3d_in_process_impl.cc > File ...
8 years, 9 months ago (2012-03-13 18:56:24 UTC) #3
apatrick_chromium
8 years, 9 months ago (2012-03-13 19:27:42 UTC) #4
I was looking at createFramebuffer which initializes o to zero before calling
glGenFramebuffers. I guess the others like createTexture don't. LGTM.

Powered by Google App Engine
This is Rietveld 408576698