Utility to create NTFS junctions points.

Utility to create NTFS junctions points.

To be used in the new git-submodule based workflow.
R=nsylvain@chromium.org,cmp@chromium.org
BUG=
TEST=

[cmp, 2012-03-14 17:43:38]

This looks like C code to me, but has a .cpp file extension, which I believe is
C++.  If this was named .c, would that cause Windows issues?

I'd like to see a demo of this when you get a chance.

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
File tools/junction/junction.cpp (right):

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
tools/junction/junction.cpp:42: int main (int argc, char *argv[])
no space after main

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
tools/junction/junction.cpp:45: char* dest_path=NULL;
spaces around = here and below

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
tools/junction/junction.cpp:73: fprintf(stderr, "%s: No such animal.\n",
src_path);
:)  Any objection to changing this to "Invalid file attributes."?

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
tools/junction/junction.cpp:100: case ERROR_ALREADY_EXISTS:
Is there a way to check for the next 2 cases before attempting to create the
directory?

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
tools/junction/junction.cpp:157: return 1;
In the other error conditions you return -1, but you return 1 here.  Is that
significant?  This error seems similar enough that it would be consistent to
return -1 here, too, I suppose.

[cmp, 2012-03-14 17:45:11]

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
File tools/junction/junction.cpp (right):

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
tools/junction/junction.cpp:72: if (GetFileAttributes(src_path) ==
INVALID_FILE_ATTRIBUTES) {
This code seems to assume that it's running on a NTFS partition.  Is that a
requirement?  Is it possible to check and exit early if that requirement isn't
met?

[szager, 2012-03-14 19:04:04]

Renamed to junction.c, which is appropriate.

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
File tools/junction/junction.cpp (right):

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
tools/junction/junction.cpp:42: int main (int argc, char *argv[])
On 2012/03/14 17:43:38, cmp wrote:
> no space after main

Done.

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
tools/junction/junction.cpp:45: char* dest_path=NULL;
On 2012/03/14 17:43:38, cmp wrote:
> spaces around = here and below

Done.

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
tools/junction/junction.cpp:72: if (GetFileAttributes(src_path) ==
INVALID_FILE_ATTRIBUTES) {
On 2012/03/14 17:45:11, cmp wrote:
> This code seems to assume that it's running on a NTFS partition.  Is that a
> requirement?  Is it possible to check and exit early if that requirement isn't
> met?

Added this check below.

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
tools/junction/junction.cpp:73: fprintf(stderr, "%s: No such animal.\n",
src_path);
On 2012/03/14 17:43:38, cmp wrote:
> :)  Any objection to changing this to "Invalid file attributes."?

Done.

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
tools/junction/junction.cpp:100: case ERROR_ALREADY_EXISTS:
On 2012/03/14 17:43:38, cmp wrote:
> Is there a way to check for the next 2 cases before attempting to create the
> directory?

There's no ordering implied in a case statement, other than checking the value
of the integer on which you're switching.  I can reorder the statements if you'd
like, but it will be a no-op change.

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
tools/junction/junction.cpp:157: return 1;
On 2012/03/14 17:43:38, cmp wrote:
> In the other error conditions you return -1, but you return 1 here.  Is that
> significant?  This error seems similar enough that it would be consistent to
> return -1 here, too, I suppose.

I usually use -1 to indicate that the program exited before the 'main' action
was even attempted, but 1 to indicate that the 'main' action was attempted and
failed.  That's just personal preference, so if there's a more appropriate
heuristic, that's fine with me.

[cmp, 2012-03-14 19:10:10]

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
File tools/junction/junction.cpp (right):

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
tools/junction/junction.cpp:100: case ERROR_ALREADY_EXISTS:
I mean what if you moved the tests for these conditions (directory already
exists, some part of the intermediate path doesn't exist) above into the tests
before line 95.  Here it seems that you're mixing the action with the tests.  I
will be fine with that, though, just checking if there are tests you could use
above to look for these conditions instead.

https://chromiumcodereview.appspot.com/9693033/diff/1/tools/junction/junction...
tools/junction/junction.cpp:157: return 1;
Ok, I'm sold. :)

[nsylvain, 2012-03-16 18:24:17]

the code looks good, but since it does not really follow the chrome code style,
we should probably move it to trunk/tools/ instead of trunk/src/tools.

https://chromiumcodereview.appspot.com/9693033/diff/5001/tools/junction/junct...
File tools/junction/junction.c (right):

https://chromiumcodereview.appspot.com/9693033/diff/5001/tools/junction/junct...
tools/junction/junction.c:119: fprintf(stderr, "Unknown error occurred while
trying to create "
you should probably print the error here.

[M-A Ruel, 2012-05-23 00:28:08]

https://chromiumcodereview.appspot.com/9693033/diff/5001/tools/junction/junct...
File tools/junction/junction.c (right):

https://chromiumcodereview.appspot.com/9693033/diff/5001/tools/junction/junct...
tools/junction/junction.c:45: char* dest_path = NULL;
I highly recommend converting everything to wchar_t and #define UNICODE 1

https://chromiumcodereview.appspot.com/9693033/diff/5001/tools/junction/junct...
tools/junction/junction.c:59: fputs("Usage: junction <destination dir> <source
dir>\n", stderr);
Why fputs here but fprintf around lines 91-92?

https://chromiumcodereview.appspot.com/9693033/diff/5001/tools/junction/junct...
tools/junction/junction.c:82: src_vol = _strdup(buf);
Head explodes. :)