Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3011)

Unified Diff: chrome/browser/resources/uber/uber_frame.js

Issue 9693032: [uber page] Split up initialization of handlers from initialization of webui pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: copyright bumps Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/uber/uber_frame.css ('k') | chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/uber/uber_frame.js
diff --git a/chrome/browser/resources/uber/uber_frame.js b/chrome/browser/resources/uber/uber_frame.js
index 0326c357f670b8d58b170c4e73a84b83fb233f5d..ede1363048901c17a9efe43e471655db2234410b 100644
--- a/chrome/browser/resources/uber/uber_frame.js
+++ b/chrome/browser/resources/uber/uber_frame.js
@@ -34,6 +34,11 @@ cr.define('uber_frame', function() {
* @param {Event} e The click event.
*/
function onNavItemClicked(e) {
+ // Though pointer-event: none; is applied to the .selected nav item, users
+ // can still tab to them and press enter/space which simulates a click.
+ if (e.target.classList.contains('selected'))
+ return;
+
uber.invokeMethodOnParent('showPage',
{pageId: e.currentTarget.getAttribute('controls')});
« no previous file with comments | « chrome/browser/resources/uber/uber_frame.css ('k') | chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698