Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: chrome/browser/ui/webui/options/password_manager_handler.cc

Issue 9693032: [uber page] Split up initialization of handlers from initialization of webui pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename Initialize -> InitializeHandler, SendPageValues -> InitializePage Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/password_manager_handler.cc
diff --git a/chrome/browser/ui/webui/options/password_manager_handler.cc b/chrome/browser/ui/webui/options/password_manager_handler.cc
index f1bbc90e27076c5a3b32fe86b790f2eb01296988..bbd9887b862d61276fa0ce50a59dce85a3fad53b 100644
--- a/chrome/browser/ui/webui/options/password_manager_handler.cc
+++ b/chrome/browser/ui/webui/options/password_manager_handler.cc
@@ -74,7 +74,7 @@ void PasswordManagerHandler::GetLocalizedValues(
chrome::kPasswordManagerLearnMoreURL);
}
-void PasswordManagerHandler::Initialize() {
+void PasswordManagerHandler::InitializeHandler() {
// Due to the way that handlers are (re)initialized under certain types of
// navigation, we may already be initialized. (See bugs 88986 and 86448.)
// If this is the case, return immediately. This is a hack.
@@ -191,7 +191,7 @@ void PasswordManagerHandler::SetPasswordList() {
// If this is the case, initialize on demand. This is a hack.
// TODO(mdm): remove this hack once it is no longer necessary.
if (show_passwords_.GetPrefName().empty())
- Initialize();
+ InitializeHandler();
ListValue entries;
bool show_passwords = *show_passwords_;

Powered by Google App Engine
This is Rietveld 408576698