chrome/browser/ui/webui/options/options_ui.cc - Issue 9693032: [uber page] Split up initialization of handlers from initialization of webui pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/options_ui.cc

Issue 9693032: [uber page] Split up initialization of handlers from initialization of webui pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rename Initialize -> InitializeHandler, SendPageValues -> InitializePage Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/options/extension_settings_handler.cc ('K') | « chrome/browser/ui/webui/options/options_ui.h ('k') | chrome/browser/ui/webui/options/pack_extension_handler.h » ('j') | chrome/browser/ui/webui/options/pack_extension_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/options_ui.cc

diff --git a/chrome/browser/ui/webui/options/options_ui.cc b/chrome/browser/ui/webui/options/options_ui.cc

index 5f0dd4661d6da9e758c4dc1767622923083ed573..74ba0ef8121a690acf9616b4b69c2b9f0f0ea553 100644

--- a/chrome/browser/ui/webui/options/options_ui.cc

+++ b/chrome/browser/ui/webui/options/options_ui.cc

@@ -336,7 +336,7 @@ void OptionsUI::InitializeHandlers() {

initialized_handlers_ = true;

for (size_t i = 0; i < handlers_.size(); ++i)

- handlers_[i]->Initialize();

+ handlers_[i]->InitializeHandler();

}

void OptionsUI::AddOptionsPageUIHandler(DictionaryValue* localized_strings,