Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2685)

Unified Diff: chrome/browser/ui/webui/options2/browser_options_handler2.cc

Issue 9693032: [uber page] Split up initialization of handlers from initialization of webui pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options2/browser_options_handler2.cc
diff --git a/chrome/browser/ui/webui/options2/browser_options_handler2.cc b/chrome/browser/ui/webui/options2/browser_options_handler2.cc
index 2a9dece6809536a8934de899e77ba214e9e2c8de..a8f272ae42afd8fc0f265d4273c1132ca3ca021c 100644
--- a/chrome/browser/ui/webui/options2/browser_options_handler2.cc
+++ b/chrome/browser/ui/webui/options2/browser_options_handler2.cc
@@ -565,7 +565,6 @@ void BrowserOptionsHandler::Initialize() {
ThemeServiceFactory::GetForProfile(profile)));
UpdateSearchEngines();
- ObserveThemeChanged();
#if defined(OS_WIN)
const CommandLine& command_line = *CommandLine::ForCurrentProcess();
@@ -603,6 +602,14 @@ void BrowserOptionsHandler::Initialize() {
proxy_prefs_.reset(
PrefSetObserver::CreateProxyPrefSetObserver(prefs, this));
#endif // !defined(OS_CHROMEOS)
+}
+
+void BrowserOptionsHandler::SendPageValues() {
+ OnTemplateURLServiceChanged();
+ ObserveThemeChanged();
+
+ if (multiprofile_)
+ SendProfilesInfo();
SetupMetricsReportingCheckbox();
SetupMetricsReportingSettingVisibility();
@@ -808,7 +815,6 @@ void BrowserOptionsHandler::UpdateSearchEngines() {
if (template_url_service_) {
template_url_service_->Load();
template_url_service_->AddObserver(this);
- OnTemplateURLServiceChanged();
}
}

Powered by Google App Engine
This is Rietveld 408576698