Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: chrome/browser/ui/webui/options/search_engine_manager_handler.cc

Issue 9693032: [uber page] Split up initialization of handlers from initialization of webui pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename Initialize -> InitializeHandler, SendPageValues -> InitializePage Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/search_engine_manager_handler.h" 5 #include "chrome/browser/ui/webui/options/search_engine_manager_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/string_number_conversions.h" 8 #include "base/string_number_conversions.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 21 matching lines...) Expand all
32 }; // namespace 32 }; // namespace
33 33
34 SearchEngineManagerHandler::SearchEngineManagerHandler() { 34 SearchEngineManagerHandler::SearchEngineManagerHandler() {
35 } 35 }
36 36
37 SearchEngineManagerHandler::~SearchEngineManagerHandler() { 37 SearchEngineManagerHandler::~SearchEngineManagerHandler() {
38 if (list_controller_.get() && list_controller_->table_model()) 38 if (list_controller_.get() && list_controller_->table_model())
39 list_controller_->table_model()->SetObserver(NULL); 39 list_controller_->table_model()->SetObserver(NULL);
40 } 40 }
41 41
42 void SearchEngineManagerHandler::Initialize() { 42 void SearchEngineManagerHandler::InitializeHandler() {
43 list_controller_.reset( 43 list_controller_.reset(
44 new KeywordEditorController(Profile::FromWebUI(web_ui()))); 44 new KeywordEditorController(Profile::FromWebUI(web_ui())));
45 if (list_controller_.get()) { 45 if (list_controller_.get()) {
46 list_controller_->table_model()->SetObserver(this); 46 list_controller_->table_model()->SetObserver(this);
47 OnModelChanged(); 47 OnModelChanged();
48 } 48 }
49 } 49 }
50 50
51 void SearchEngineManagerHandler::GetLocalizedValues( 51 void SearchEngineManagerHandler::GetLocalizedValues(
52 base::DictionaryValue* localized_strings) { 52 base::DictionaryValue* localized_strings) {
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 string16 keyword; 305 string16 keyword;
306 std::string url; 306 std::string url;
307 if (!args->GetString(ENGINE_NAME, &name) || 307 if (!args->GetString(ENGINE_NAME, &name) ||
308 !args->GetString(ENGINE_KEYWORD, &keyword) || 308 !args->GetString(ENGINE_KEYWORD, &keyword) ||
309 !args->GetString(ENGINE_URL, &url)) { 309 !args->GetString(ENGINE_URL, &url)) {
310 NOTREACHED(); 310 NOTREACHED();
311 return; 311 return;
312 } 312 }
313 edit_controller_->AcceptAddOrEdit(name, keyword, url); 313 edit_controller_->AcceptAddOrEdit(name, keyword, url);
314 } 314 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698