Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: chrome/browser/ui/webui/options/options_ui.h

Issue 9693032: [uber page] Split up initialization of handlers from initialization of webui pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename Initialize -> InitializeHandler, SendPageValues -> InitializePage Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_OPTIONS_UI_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_OPTIONS_UI_H_
6 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_OPTIONS_UI_H_ 6 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_OPTIONS_UI_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 15 matching lines...) Expand all
26 virtual ~OptionsPageUIHandler(); 26 virtual ~OptionsPageUIHandler();
27 27
28 // Is this handler enabled? 28 // Is this handler enabled?
29 virtual bool IsEnabled(); 29 virtual bool IsEnabled();
30 30
31 // Collects localized strings for options page. 31 // Collects localized strings for options page.
32 virtual void GetLocalizedValues(base::DictionaryValue* localized_strings) = 0; 32 virtual void GetLocalizedValues(base::DictionaryValue* localized_strings) = 0;
33 33
34 // Initialize the page. Called once the DOM is available for manipulation. 34 // Initialize the page. Called once the DOM is available for manipulation.
35 // This will be called only once. 35 // This will be called only once.
36 virtual void Initialize() {} 36 virtual void InitializeHandler() {}
37
38 // Actually sends down values after initialization to the webui page.
39 virtual void InitializePage() {}
37 40
38 // Uninitializes the page. Called just before the object is destructed. 41 // Uninitializes the page. Called just before the object is destructed.
39 virtual void Uninitialize() {} 42 virtual void Uninitialize() {}
40 43
41 // WebUIMessageHandler implementation. 44 // WebUIMessageHandler implementation.
42 virtual void RegisterMessages() OVERRIDE {} 45 virtual void RegisterMessages() OVERRIDE {}
43 46
44 // content::NotificationObserver implementation. 47 // content::NotificationObserver implementation.
45 virtual void Observe(int type, 48 virtual void Observe(int type,
46 const content::NotificationSource& source, 49 const content::NotificationSource& source,
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 void SetCommandLineString(content::RenderViewHost* render_view_host); 111 void SetCommandLineString(content::RenderViewHost* render_view_host);
109 112
110 bool initialized_handlers_; 113 bool initialized_handlers_;
111 114
112 std::vector<OptionsPageUIHandler*> handlers_; 115 std::vector<OptionsPageUIHandler*> handlers_;
113 116
114 DISALLOW_COPY_AND_ASSIGN(OptionsUI); 117 DISALLOW_COPY_AND_ASSIGN(OptionsUI);
115 }; 118 };
116 119
117 #endif // CHROME_BROWSER_UI_WEBUI_OPTIONS_OPTIONS_UI_H_ 120 #endif // CHROME_BROWSER_UI_WEBUI_OPTIONS_OPTIONS_UI_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698