Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: chrome/browser/ui/webui/options/extension_settings_handler.cc

Issue 9693032: [uber page] Split up initialization of handlers from initialization of webui pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename Initialize -> InitializeHandler, SendPageValues -> InitializePage Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/extension_settings_handler.h" 5 #include "chrome/browser/ui/webui/options/extension_settings_handler.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/base64.h" 8 #include "base/base64.h"
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 569 matching lines...) Expand 10 before | Expand all | Expand 10 after
580 l10n_util::GetStringUTF16(IDS_EXTENSIONS_SHOW_DETAILS)); 580 l10n_util::GetStringUTF16(IDS_EXTENSIONS_SHOW_DETAILS));
581 localized_strings->SetString("extensionSettingsHideDetails", 581 localized_strings->SetString("extensionSettingsHideDetails",
582 l10n_util::GetStringUTF16(IDS_EXTENSIONS_HIDE_DETAILS)); 582 l10n_util::GetStringUTF16(IDS_EXTENSIONS_HIDE_DETAILS));
583 583
584 // TODO(estade): comb through the above strings to find ones no longer used in 584 // TODO(estade): comb through the above strings to find ones no longer used in
585 // uber extensions. 585 // uber extensions.
586 localized_strings->SetString("extensionUninstall", 586 localized_strings->SetString("extensionUninstall",
587 l10n_util::GetStringUTF16(IDS_EXTENSIONS_UNINSTALL)); 587 l10n_util::GetStringUTF16(IDS_EXTENSIONS_UNINSTALL));
588 } 588 }
589 589
590 void ExtensionSettingsHandler::Initialize() { 590 void ExtensionSettingsHandler::InitializeHandler() {
Dan Beam 2012/03/13 23:01:45 and this
591 } 591 }
592 592
593 void ExtensionSettingsHandler::Observe( 593 void ExtensionSettingsHandler::Observe(
594 int type, 594 int type,
595 const content::NotificationSource& source, 595 const content::NotificationSource& source,
596 const content::NotificationDetails& details) { 596 const content::NotificationDetails& details) {
597 Profile* profile = Profile::FromWebUI(web_ui()); 597 Profile* profile = Profile::FromWebUI(web_ui());
598 Profile* source_profile = NULL; 598 Profile* source_profile = NULL;
599 switch (type) { 599 switch (type) {
600 // We listen for notifications that will result in the page being 600 // We listen for notifications that will result in the page being
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
781 chrome::VIEW_TYPE_EXTENSION_DIALOG == host_type) 781 chrome::VIEW_TYPE_EXTENSION_DIALOG == host_type)
782 continue; 782 continue;
783 783
784 GURL url = host->GetDelegate()->GetURL(); 784 GURL url = host->GetDelegate()->GetURL();
785 content::RenderProcessHost* process = host->GetProcess(); 785 content::RenderProcessHost* process = host->GetProcess();
786 result->push_back( 786 result->push_back(
787 ExtensionPage(url, process->GetID(), host->GetRoutingID(), 787 ExtensionPage(url, process->GetID(), host->GetRoutingID(),
788 process->GetBrowserContext()->IsOffTheRecord())); 788 process->GetBrowserContext()->IsOffTheRecord()));
789 } 789 }
790 } 790 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698