Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Side by Side Diff: chrome/browser/ui/webui/options/chromeos/virtual_keyboard_manager_handler.cc

Issue 9693032: [uber page] Split up initialization of handlers from initialization of webui pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename Initialize -> InitializeHandler, SendPageValues -> InitializePage Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/chromeos/virtual_keyboard_manager_hand ler.h" 5 #include "chrome/browser/ui/webui/options/chromeos/virtual_keyboard_manager_hand ler.h"
6 6
7 #include <map> 7 #include <map>
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 }; 52 };
53 RegisterStrings(localized_strings, resources, arraysize(resources)); 53 RegisterStrings(localized_strings, resources, arraysize(resources));
54 54
55 RegisterTitle(localized_strings, "virtualKeyboardPage", 55 RegisterTitle(localized_strings, "virtualKeyboardPage",
56 IDS_OPTIONS_SETTINGS_LANGUAGES_VIRTUAL_KEYBOARD_SETTINGS_TITLE); 56 IDS_OPTIONS_SETTINGS_LANGUAGES_VIRTUAL_KEYBOARD_SETTINGS_TITLE);
57 57
58 // Do not call GetVirtualKeyboardList() here since |web_ui()| is not ready 58 // Do not call GetVirtualKeyboardList() here since |web_ui()| is not ready
59 // yet. 59 // yet.
60 } 60 }
61 61
62 void VirtualKeyboardManagerHandler::Initialize() { 62 void VirtualKeyboardManagerHandler::InitializeHandler() {
Dan Beam 2012/03/13 23:01:45 and this
63 } 63 }
64 64
65 void VirtualKeyboardManagerHandler::RegisterMessages() { 65 void VirtualKeyboardManagerHandler::RegisterMessages() {
66 // Register handler functions for chrome.send(). 66 // Register handler functions for chrome.send().
67 web_ui()->RegisterMessageCallback("updateVirtualKeyboardList", 67 web_ui()->RegisterMessageCallback("updateVirtualKeyboardList",
68 base::Bind(&VirtualKeyboardManagerHandler::UpdateVirtualKeyboardList, 68 base::Bind(&VirtualKeyboardManagerHandler::UpdateVirtualKeyboardList,
69 base::Unretained(this))); 69 base::Unretained(this)));
70 web_ui()->RegisterMessageCallback("setVirtualKeyboardPreference", 70 web_ui()->RegisterMessageCallback("setVirtualKeyboardPreference",
71 base::Bind(&VirtualKeyboardManagerHandler::SetVirtualKeyboardPreference, 71 base::Bind(&VirtualKeyboardManagerHandler::SetVirtualKeyboardPreference,
72 base::Unretained(this))); 72 base::Unretained(this)));
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 virtual_keyboard->SetString("name", i->second->name()); 226 virtual_keyboard->SetString("name", i->second->name());
227 virtual_keyboard->SetBoolean("isSystem", i->second->is_system()); 227 virtual_keyboard->SetBoolean("isSystem", i->second->is_system());
228 virtual_keyboard->SetString("url", i->second->url().spec()); 228 virtual_keyboard->SetString("url", i->second->url().spec());
229 supported_keyboards->Append(virtual_keyboard); 229 supported_keyboards->Append(virtual_keyboard);
230 } 230 }
231 231
232 return layout_list; 232 return layout_list;
233 } 233 }
234 234
235 } // namespace chromeos 235 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698