Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: chrome/browser/chromeos/login/language_switch_menu.cc

Issue 9693022: views: Rename MenuButtonDelegate::RunMenu to something more obvious. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: menu_button_listener.h Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/language_switch_menu.cc
diff --git a/chrome/browser/chromeos/login/language_switch_menu.cc b/chrome/browser/chromeos/login/language_switch_menu.cc
index 63ee4524155f880cbce73056454c0a34627416e7..890b8c573ad56e851eaa1c8ab8f9637c94b3ddac 100644
--- a/chrome/browser/chromeos/login/language_switch_menu.cc
+++ b/chrome/browser/chromeos/login/language_switch_menu.cc
@@ -190,21 +190,22 @@ void LanguageSwitchMenu::SwitchLanguageAndEnableKeyboardLayouts(
}
////////////////////////////////////////////////////////////////////////////////
-// views::MenuButtonDelegate implementation.
+// views::MenuButtonListener implementation.
-void LanguageSwitchMenu::RunMenu(views::View* source, const gfx::Point& pt) {
+void LanguageSwitchMenu::OnMenuButtonClicked(views::View* source,
+ const gfx::Point& point) {
DCHECK(menu_ != NULL);
views::MenuButton* button = static_cast<views::MenuButton*>(source);
// We align on the left edge of the button for non RTL case.
- // MenuButton passes in pt the lower left corner for RTL and the
+ // MenuButton passes in |point| the lower left corner for RTL and the
// lower right corner for non-RTL (with menu_offset applied).
const int reverse_offset = button->width() + button->menu_offset().x() * 2;
- gfx::Point new_pt(pt);
+ gfx::Point new_pt(point);
if (base::i18n::IsRTL())
- new_pt.set_x(pt.x() + reverse_offset);
+ new_pt.set_x(point.x() + reverse_offset);
else
- new_pt.set_x(pt.x() - reverse_offset);
+ new_pt.set_x(point.x() - reverse_offset);
if (menu_runner_->RunMenuAt(button->GetWidget(), button,
gfx::Rect(new_pt, gfx::Size()), views::MenuItemView::TOPLEFT,
« no previous file with comments | « chrome/browser/chromeos/login/language_switch_menu.h ('k') | chrome/browser/chromeos/notifications/balloon_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698