Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9693022: views: Rename MenuButtonDelegate::RunMenu to something more obvious. (Closed)

Created:
8 years, 9 months ago by tfarina
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, dcheng, dmazzoni+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, aboxhall+watch_chromium.org, Andrei, jennb, jianli, yuzo+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, Dmitry Lomov (no reviews), hashimoto+watch_chromium.org, tfarina, Dmitry Titov, davidbarr+watch_chromium.org, Aaron Boodman, dtseng+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

views: Rename MenuButtonDelegate::RunMenu to something more obvious. The reason is that there are a lot of RunMenu() functions all over the code, and actually the event for this function is that the menu button was pressed. So we tell that to subclasses and they do whatever they want; they do not necessarily need to run a menu. Thus this patch renames RunMenu to OnMenuButtonClicked. BUG=117092 R=sky@chromium.org TBR=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126967

Patch Set 1 : #

Patch Set 2 : MenuButtonListener #

Patch Set 3 : menu_button_listener.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -238 lines) Patch
M chrome/browser/chromeos/login/language_switch_menu.h View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/language_switch_menu.cc View 1 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/notifications/balloon_view.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/status/accessibility_menu_button.h View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/status/accessibility_menu_button.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/status/caps_lock_menu_button.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/status/caps_lock_menu_button.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/status/clock_menu_button.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/status/clock_menu_button.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu.h View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu_button.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu_button.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/status/memory_menu_button.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/status/memory_menu_button.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/network_menu_button.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu_button.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/status/power_menu_button.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/status/power_menu_button.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/status/status_area_button.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/status/status_area_button.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/status/volume_menu_button.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/status/volume_menu_button.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/app_menu_button_win.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/app_menu_button_win.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_button.h View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_button.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 1 2 4 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/browser_actions_container.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
chrome/browser/ui/views/browser_actions_container.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/after_translate_infobar.h View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/infobars/after_translate_infobar.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/infobars/before_translate_infobar.h View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/infobars/before_translate_infobar.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/infobars/extension_infobar.h View 1 2 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/infobars/extension_infobar.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/infobars/media_stream_infobar.h View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/infobars/media_stream_infobar.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/menu_item_view_test.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/menu_model_adapter_test.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/status_icons/status_icon_chromeos.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar_view.h View 1 2 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/controls/button/menu_button.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/button/menu_button.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M ui/views/controls/button/menu_button_delegate.h View 1 1 chunk +0 lines, -40 lines 0 comments Download
A ui/views/controls/button/menu_button_listener.h View 1 1 chunk +31 lines, -0 lines 0 comments Download
M ui/views/examples/menu_example.cc View 1 2 3 chunks +7 lines, -5 lines 0 comments Download
M ui/views/views.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
8 years, 9 months ago (2012-03-14 17:42:13 UTC) #1
sky
8 years, 9 months ago (2012-03-15 16:26:09 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698