Issue 9693014: Add support for unpacked extensions to crx_id tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9693014: Add support for unpacked extensions to crx_id tool. (Closed)

Created:
8 years, 9 months ago by jvoung - send to chromium...

Modified:
8 years, 9 months ago

Reviewers:
jstritar

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add support for unpacked extensions to crx_id tool. BUG=117778 TEST= crx_id_unittest.py Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126740

Patch Set 2 : handle path without keys #

Patch Set 3 : typo #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -34 lines)			Patch
	M	tools/crx_id/crx_id.py	View	1 2	3 chunks	+55 lines, -16 lines	0 comments	Download
	M	tools/crx_id/crx_id_unittest.py	View	1	2 chunks	+60 lines, -18 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jvoung - send to chromium...

sending w/ real email address this time...

8 years, 9 months ago (2012-03-12 21:58:48 UTC) #2

jstritar

http://codereview.chromium.org/9693014/diff/1/tools/crx_id/crx_id.py File tools/crx_id/crx_id.py (right): http://codereview.chromium.org/9693014/diff/1/tools/crx_id/crx_id.py#newcode80 tools/crx_id/crx_id.py:80: if 'key' not in manifest: I wonder if you ...

8 years, 9 months ago (2012-03-13 16:55:52 UTC) #3

LGTM thanks!