net: always enable NSS's HTTP fetches

net/ocsp/nss_ocsp.h

Index: net/ocsp/nss_ocsp.h
diff --git a/net/ocsp/nss_ocsp.h b/net/ocsp/nss_ocsp.h
index bf67751329643ac65c2a723eb81962f79cb8a869..b5e7306dea050abe2c1163eb48d1c04fa3dbc31b 100644
--- a/net/ocsp/nss_ocsp.h
+++ b/net/ocsp/nss_ocsp.h
@@ -12,22 +12,24 @@ namespace net {
 
 class URLRequestContext;
 
-// Sets the MessageLoop for OCSP to the current message loop.
-// This should be called before EnsureOCSPInit() if you want to
-// control the message loop for OCSP.
-NET_EXPORT void SetMessageLoopForOCSP();
+// Sets the MessageLoop for NSS's PKIX related IO (i.e. OCSP, AIA and CRL

[wtc, 2012/03/12 22:38:11]

Nit: PKIX related IO => HTTP client functions

This reflects the name of the NSS function
SEC_RegisterDefaultHttpClient:
http://mxr.mozilla.org/security/ident?i=SEC_RegisterDefaultHttpClient

Nit: AIA => CA certificate

+// fetches) to the current message loop.  This should be called before
+// EnsureOCSPInit() if you want to control the message loop for OCSP.

[wtc, 2012/03/12 22:38:11]

EnsureOCSPInit() and "for OCSP" need to be updated.

[agl, 2012/03/13 15:14:05]

Done.

+NET_EXPORT void SetMessageLoopForNssPkixIO();

[wtc, 2012/03/12 22:38:11]

Please name this NSSHttpClient or NSSHttpIO.  NSS can use it
for any HTTP operation, not limited to use by libpkix.

[agl, 2012/03/13 15:14:05]

Renamed to NSSHttpIO.

 
-// Initializes OCSP handlers for NSS.  This must be called before any
+// Initializes IO handlers for NSS.  This must be called before any

[wtc, 2012/03/12 22:38:11]

IO handlers => HTTP client functions

The "OCSP handlers" on lines 21-22 should also be changed.

[agl, 2012/03/13 15:14:05]

Done.

 // certificate verification functions.  This function is thread-safe, and OCSP
-// handlers will only ever be initialized once.  ShutdownOCSP() must be called
-// on shutdown.
-NET_EXPORT void EnsureOCSPInit();
+// handlers will only ever be initialized once.  ShutdownNssPkixIO() must be
+// called on shutdown.
+NET_EXPORT void EnsureNssPkixIOInit();
 
-// This should be called once on shutdown to stop issuing URLRequests for OCSP.
-NET_EXPORT void ShutdownOCSP();
+// This should be called once on shutdown to stop issuing URLRequests for PKIX
+// related fetches.
+NET_EXPORT void ShutdownNssPkixIO();
 
-// Set URLRequestContext for OCSP handlers.
-NET_EXPORT void SetURLRequestContextForOCSP(URLRequestContext* request_context);
+// Set URLRequestContext for PKIX related fetches.

[wtc, 2012/03/12 22:38:11]

On lines 26-27 and this line, change
PKIX related fetches => HTTP requests issued by NSS

or you can say "certificate related HTTP requests".

I think "PKIX" is a little obscure.

[agl, 2012/03/13 15:14:05]

Done.

+NET_EXPORT void SetURLRequestContextForNssPkixIO(
+    URLRequestContext* request_context);
 
 }  // namespace net