Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 9693001: Remove invalid assert from test.dart, that webdriver tests require DumpRenderTree. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 424 matching lines...) Expand 10 before | Expand all | Expand 10 after
435 String filename = info.filename; 435 String filename = info.filename;
436 if (optionsFromFile['isMultitest']) return; 436 if (optionsFromFile['isMultitest']) return;
437 bool isWebTest = optionsFromFile['containsDomImport']; 437 bool isWebTest = optionsFromFile['containsDomImport'];
438 bool isLibraryDefinition = optionsFromFile['isLibraryDefinition']; 438 bool isLibraryDefinition = optionsFromFile['isLibraryDefinition'];
439 if (!isLibraryDefinition && optionsFromFile['containsSourceOrImport']) { 439 if (!isLibraryDefinition && optionsFromFile['containsSourceOrImport']) {
440 print('Warning for $filename: Browser tests require #library ' + 440 print('Warning for $filename: Browser tests require #library ' +
441 'in any file that uses #import, #source, or #resource'); 441 'in any file that uses #import, #source, or #resource');
442 } 442 }
443 443
444 final String component = configuration['component']; 444 final String component = configuration['component'];
445 Expect.isTrue(DumpRenderTreeUpdater.componentRequiresDRT(component));
446 final String testPath = 445 final String testPath =
447 new File(filename).fullPathSync().replaceAll('\\', '/'); 446 new File(filename).fullPathSync().replaceAll('\\', '/');
448 447
449 for (var vmOptions in optionsFromFile['vmOptions']) { 448 for (var vmOptions in optionsFromFile['vmOptions']) {
450 // Create a unique temporary directory for each set of vmOptions. 449 // Create a unique temporary directory for each set of vmOptions.
451 // TODO(dart:429): Replace separate replaceAlls with a RegExp when 450 // TODO(dart:429): Replace separate replaceAlls with a RegExp when
452 // replaceAll(RegExp, String) is implemented. 451 // replaceAll(RegExp, String) is implemented.
453 String optionsName = ''; 452 String optionsName = '';
454 if (optionsFromFile['vmOptions'].length > 1) { 453 if (optionsFromFile['vmOptions'].length > 1) {
455 optionsName = Strings.join(vmOptions, '-').replaceAll('-','') 454 optionsName = Strings.join(vmOptions, '-').replaceAll('-','')
(...skipping 779 matching lines...) Expand 10 before | Expand all | Expand 10 after
1235 * $noCrash tests are expected to be flaky but not crash 1234 * $noCrash tests are expected to be flaky but not crash
1236 * $pass tests are expected to pass 1235 * $pass tests are expected to pass
1237 * $failOk tests are expected to fail that we won't fix 1236 * $failOk tests are expected to fail that we won't fix
1238 * $fail tests are expected to fail that we should fix 1237 * $fail tests are expected to fail that we should fix
1239 * $crash tests are expected to crash that we should fix 1238 * $crash tests are expected to crash that we should fix
1240 * $timeout tests are allowed to timeout 1239 * $timeout tests are allowed to timeout
1241 """; 1240 """;
1242 print(report); 1241 print(report);
1243 } 1242 }
1244 } 1243 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698