Issue 9692072: Clean up some sync integration test code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9692072: Clean up some sync integration test code. (Closed)

Created:
8 years, 9 months ago by Peter Kasting

Modified:
8 years, 9 months ago

Reviewers:
Raghu Simha, SteveT

CC:
chromium-reviews, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Clean up some sync integration test code: * Move all TemplateURL creation into a single core CreateTestTemplateURL() function. This will ease the later TemplateURL refactoring changes that will modify how TemplateURLs are created and modified. * Make use of the TemplateURLService::TemplateURLVector typedef. * Pass string16s to EditSearchEngine() since that's what it really wants. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126744

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -53 lines)			Patch
M	chrome/browser/sync/test/integration/search_engines_helper.h	View	2 chunks	+11 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/test/integration/search_engines_helper.cc	View	5 chunks	+40 lines, -27 lines	0 comments	Download
M	chrome/browser/sync/test/integration/two_client_search_engines_sync_test.cc	View	6 chunks	+15 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages