Gave native File Browser file handlers higher priority than 3rd party handlers.

chrome/browser/chromeos/extensions/file_handler_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_HANDLER_UTIL_H_
 #define CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_HANDLER_UTIL_H_
 #pragma once
 
 #include "base/platform_file.h"
 #include "chrome/common/extensions/extension.h"
@@ skipping 24 matching lines @@
 
   int timestamp;
   const FileBrowserHandler* handler;
   URLPatternSet patterns;
 };
 
 typedef std::vector<LastUsedHandler> LastUsedHandlerList;
 
 bool FindCommonTasks(Profile* profile,
                      const std::vector<GURL>& files_list,
+                     const std::string& privileged_extension_id,

[SeRya, 2012/03/14 11:44:57]

Could this parameter different from kFileBrowserDomain? If not let's use the
constant instead of variable and not pretend we have flexibility here.

[Vladislav Kaznacheev, 2012/03/14 12:01:05]

It is not about flexibility but about dependencies. Currently
file_handler_util.cc does not include file_manager_util.h and I like it.
On 2012/03/14 11:44:57, SeRya wrote:

[SeRya, 2012/03/14 12:19:22]

Could we resolve the dependency issue not touching public API?
file_handler_util.cc may be shouldn't know File Manager but it may distinguish
component extensions from installed extensions.

On 2012/03/14 12:01:05, Vladislav Kaznacheev wrote:

[Vladislav Kaznacheev, 2012/03/14 12:28:07]

Checking for component extensions is not enough. The bug that I am fixing is
about the conflict between File Manager and Picasa Uploader which is a component
extension too.

On 2012/03/14 12:19:22, SeRya wrote:

[dgozman, 2012/03/14 13:31:11]

AFAIK, Picasa Uploader is not a component extension.
However, I'm fine with this approach.

On 2012/03/14 12:28:07, Vladislav Kaznacheev wrote:

                      LastUsedHandlerList* named_action_list);
 
 bool GetDefaultTask(Profile* profile,
                     const GURL& url,
+                    const std::string& privileged_extension_id,
                     const FileBrowserHandler** handler);
 
 class FileTaskExecutor : public base::RefCountedThreadSafe<FileTaskExecutor> {
  public:
 
   FileTaskExecutor(Profile* profile,
                    const GURL source_url,
                    const std::string& extension_id,
                    const std::string& action_id);
 
@@ skipping 29 matching lines @@
 
   Profile* profile_;
   const GURL source_url_;
   const std::string extension_id_;
   const std::string action_id_;
 };
 
 }  // namespace file_handler_util
 
 #endif  // CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_HANDLER_UTIL_H_