Issue 9692046: Always create HArgumentsObject on function entry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9692046: Always create HArgumentsObject on function entry. (Closed)

Created:
8 years, 9 months ago by Vyacheslav Egorov (Chromium)

Modified:
8 years, 9 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Always create HArgumentsObject on function entry. We do not know if we are going to need it and creating it lazyly might cause us to insert it at the block that does not dominate all uses. R=mstarzinger@chromium.org TEST=mjsunit/compiler/inline-arguments.js Committed: https://code.google.com/p/v8/source/detail?r=11024

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -11 lines)			Patch
M	src/hydrogen.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/hydrogen.cc	View	3 chunks	+4 lines, -10 lines	0 comments	Download
M	test/mjsunit/compiler/inline-arguments.js	View	1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages