stopping the audio thread before destroying the AudioManager<Platform>

media/audio/fake_audio_input_stream.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A fake implementation of AudioInputStream, useful for testing purpose.
 
 #ifndef MEDIA_AUDIO_FAKE_AUDIO_INPUT_STREAM_H_
 #define MEDIA_AUDIO_FAKE_AUDIO_INOUT_STREAM_H_
 
 #include <vector>
 
-#include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/threading/thread.h"
 #include "base/time.h"
 #include "media/audio/audio_io.h"
 #include "media/audio/audio_parameters.h"
 
+class AudioManagerBase;
+
 class FakeAudioInputStream
-    : public AudioInputStream,
-      public base::RefCountedThreadSafe<FakeAudioInputStream> {
+    : public AudioInputStream {
  public:
-  static AudioInputStream* MakeFakeStream(const AudioParameters& params);
+  static AudioInputStream* MakeFakeStream(AudioManagerBase* manager,
+                                          const AudioParameters& params);
+
+  virtual ~FakeAudioInputStream();

[tommi (sloooow) - chröme, 2012/03/13 14:16:52]

make the destructor private so that tests can't make the mistake of trying to
delete it without calling Close()?

[no longer working on chromium, 2012/03/13 15:03:39]

Done.

 
   virtual bool Open() OVERRIDE;
   virtual void Start(AudioInputCallback* callback) OVERRIDE;
   virtual void Stop() OVERRIDE;
   virtual void Close() OVERRIDE;
   virtual double GetMaxVolume() OVERRIDE;
   virtual void SetVolume(double volume) OVERRIDE;
   virtual double GetVolume() OVERRIDE;
 
  private:
-  // Give RefCountedThreadSafe access our destructor.
-  friend class base::RefCountedThreadSafe<FakeAudioInputStream>;
 
-  FakeAudioInputStream(const AudioParameters& params);
-  virtual ~FakeAudioInputStream();
+  FakeAudioInputStream(AudioManagerBase* manager,
+                       const AudioParameters& params);
 
   void DoCallback();
 
+  AudioManagerBase* audio_manager_;
   AudioInputCallback* callback_;
   scoped_array<uint8> buffer_;
   int buffer_size_;
   base::Thread thread_;
   base::Time last_callback_time_;
   base::TimeDelta callback_interval_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeAudioInputStream);
 };
 
 #endif  // MEDIA_AUDIO_FAKE_AUDIO_INPUT_STREAM_H_