Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 9692036: Implement non-generic stores for object literals. (Closed)

Created:
8 years, 9 months ago by Michael Starzinger
Modified:
8 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Implement non-generic stores for object literals. This uses the type feedback already present for computed value stores into object literals to generate optimized stores in Crankshaft, thus avoiding unnecessary generic stores with side effects. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11023

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments by Sven Panne. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -8 lines) Patch
M src/ast.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M src/ast.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/hydrogen.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +22 lines, -8 lines 0 comments Download
M src/type-info.h View 3 chunks +4 lines, -0 lines 0 comments Download
M src/type-info.cc View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
8 years, 9 months ago (2012-03-13 09:18:02 UTC) #1
Sven Panne
LGTM with a nit. https://chromiumcodereview.appspot.com/9692036/diff/1/src/ast.h File src/ast.h (right): https://chromiumcodereview.appspot.com/9692036/diff/1/src/ast.h#newcode1344 src/ast.h:1344: bool is_monomorphic_; I don't think ...
8 years, 9 months ago (2012-03-13 09:46:00 UTC) #2
Michael Starzinger
8 years, 9 months ago (2012-03-13 12:12:31 UTC) #3
Added new patch set. Landed.

Powered by Google App Engine
This is Rietveld 408576698