Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: dart/frog/leg/ssa/builder.dart

Issue 9692018: Unresolved super-send is not a compile-time error. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/frog/leg/ssa/builder.dart
diff --git a/dart/frog/leg/ssa/builder.dart b/dart/frog/leg/ssa/builder.dart
index c44ee477902a26cbcca13f977b68aa433720a153..765ea257ec8d90e0ba3428f8ef951d2e9ee3c7c9 100644
--- a/dart/frog/leg/ssa/builder.dart
+++ b/dart/frog/leg/ssa/builder.dart
@@ -1777,6 +1777,10 @@ class SsaBuilder implements Visitor {
visitSuperSend(Send node) {
Selector selector = elements.getSelector(node);
Element element = elements[node];
+ if (element === null) {
+ // Example: co19/Language/10_Expressions/25_Unary_Expressions_A06_t01
+ compiler.unimplemented('unresolved super-send', node: node);
+ }
if (element.kind.category != ElementCategory.FUNCTION) {
// Example:
// co19/Language/10_Expressions/14_Method_Invocation/3_Super_Invocation_A03_t04
@@ -1818,14 +1822,17 @@ class SsaBuilder implements Visitor {
}
visitSend(Send node) {
- if (node.selector is Operator && methodInterceptionEnabled) {
+ if (node.isSuperCall) {
+ if (node.isPropertyAccess) {
+ compiler.unimplemented('super property read', node: node);
+ }
+ visitSuperSend(node);
+ } else if (node.selector is Operator && methodInterceptionEnabled) {
visitOperatorSend(node);
} else if (node.isPropertyAccess) {
generateGetter(node, elements[node]);
} else if (Elements.isClosureSend(node, elements)) {
visitClosureSend(node);
- } else if (node.isSuperCall) {
- visitSuperSend(node);
} else {
Element element = elements[node];
if (element === null) {
@@ -1854,7 +1861,9 @@ class SsaBuilder implements Visitor {
visitSendSet(SendSet node) {
Operator op = node.assignmentOperator;
- if (node.isIndex) {
+ if (node.isSuperCall) {
+ compiler.unimplemented('super property store', node: node);
+ } else if (node.isIndex) {
if (!methodInterceptionEnabled) {
assert(op.source.stringValue === '=');
visitDynamicSend(node);

Powered by Google App Engine
This is Rietveld 408576698