Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1412)

Unified Diff: dart/frog/leg/compiler.dart

Issue 9692018: Unresolved super-send is not a compile-time error. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/frog/leg/resolver.dart » ('j') | dart/frog/leg/resolver.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/compiler.dart
diff --git a/dart/frog/leg/compiler.dart b/dart/frog/leg/compiler.dart
index 0322d64718e248aa095974fc1818e3b38edc9616..cae23c4d7602063ad95f233c6481f6281f273c16 100644
--- a/dart/frog/leg/compiler.dart
+++ b/dart/frog/leg/compiler.dart
@@ -376,7 +376,7 @@ class Compiler implements DiagnosticListener {
final startOffset = begin.charOffset;
// TODO(ahe): Compute proper end offset.
final endOffset =
- (end.next !== null) ? end.next.charOffset : startOffset + 1;
+ Math.max((end.next !== null) ? end.next.charOffset : 0, startOffset + 1);
kasperl 2012/03/13 08:55:30 It's a bit hard to read and understand this line n
ahe 2012/03/13 09:12:11 Done.
Uri uri = currentElement.getCompilationUnit().script.uri;
return new SourceSpan(uri, startOffset, endOffset);
}
« no previous file with comments | « no previous file | dart/frog/leg/resolver.dart » ('j') | dart/frog/leg/resolver.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698