An internal intents dispatcher useful for initiating an intent from the browser process.

content/browser/intents/internal_web_intents_dispatcher.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_INTENTS_INTERNAL_WEB_INTENTS_DISPATCHER_H_
+#define CONTENT_BROWSER_INTENTS_INTERNAL_WEB_INTENTS_DISPATCHER_H_
+
+#include <vector>
+#include "base/callback.h"

[James Hawkins, 2012/03/12 23:19:11]

nit: Blank line in between std includes and src includes.

[Greg Billock, 2012/03/12 23:52:22]

Done.

+#include "base/compiler_specific.h"
+#include "content/public/browser/web_intents_dispatcher.h"
+#include "webkit/glue/web_intent_data.h"
+
+class IntentInjector;
+
+// This class implements a web intents coordinator object which originates

[James Hawkins, 2012/03/12 23:19:11]

We use coordinator in the comment and dispatcher in the code: should we
reconcile?

[Greg Billock, 2012/03/12 23:52:22]

Reworded a bit.

+// within the browser process rather than with a particular renderer.
+// It will terminate callbacks by notifying its delegate rather than returning

[James Hawkins, 2012/03/12 23:19:11]

We should probably expand on some of the terminology here, as it's confusing
w/out knowing all of the Web Intents context, e.g.,

"...terminate callbacks sent from the active service..."

[James Hawkins, 2012/03/12 23:19:11]

Optional nit: "It" is less ambiguous in class-level documentation, but please
try to remove the pronoun (since pronouns in comments are ambiguous).

[Greg Billock, 2012/03/12 23:52:22]

Done.

[Greg Billock, 2012/03/12 23:52:22]

Done.

+// those messages to a renderer.
+class InternalWebIntentsDispatcher : public content::WebIntentsDispatcher {
+ public:
+  // |intent| is the intent payload to be dispatched.
+  explicit InternalWebIntentsDispatcher(
+      const webkit_glue::WebIntentData& intent);
+
+  // |intent| is the intent payload to be dispatched.
+  // |reply_callback| is the callback to notify when the intent is replied to.
+  InternalWebIntentsDispatcher(
+      const webkit_glue::WebIntentData& intent,
+      base::Callback<void(webkit_glue::WebIntentReplyType,

[James Hawkins, 2012/03/12 23:19:11]

typedef this.

[Greg Billock, 2012/03/12 23:52:22]

Done.

+                          const string16&)> reply_callback);
+
+  virtual ~InternalWebIntentsDispatcher();
+
+  // WebIntentsDispatcher implementation.
+  virtual const webkit_glue::WebIntentData& GetIntent() OVERRIDE;
+  virtual void DispatchIntent(content::WebContents* destination_tab) OVERRIDE;
+  virtual void SendReplyMessage(webkit_glue::WebIntentReplyType reply_type,
+                                const string16& data) OVERRIDE;
+  virtual void RegisterReplyNotification(
+      const base::Callback<void(webkit_glue::WebIntentReplyType)>&
+          closure) OVERRIDE;
+
+ private:
+  webkit_glue::WebIntentData intent_;

[James Hawkins, 2012/03/12 23:19:11]

Document member variable.

[Greg Billock, 2012/03/12 23:52:22]

Done.

+
+  // Weak pointer to the internal object which provides the intent to the
+  // newly-created service tab contents. This object is self-deleting
+  // (connected to the service TabContents).
+  IntentInjector* intent_injector_;
+
+  // Callbacks to be notified when SendReplyMessage is called.
+  std::vector<base::Callback<void(webkit_glue::WebIntentReplyType)> >
+      reply_notifiers_;
+
+  // Callback to be invoked when the intent is replied to.
+  base::Callback<void(webkit_glue::WebIntentReplyType,
+                      const string16&)> reply_callback_;
+
+  DISALLOW_COPY_AND_ASSIGN(InternalWebIntentsDispatcher);
+};
+
+#endif  // CONTENT_BROWSER_INTENTS_INTERNAL_WEB_INTENTS_DISPATCHER_H_