Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 9692016: Revert 120593 - Ensure the previously active browser window gets the focus after a browser window i… (Closed)

Created:
8 years, 9 months ago by Wez
Modified:
8 years, 9 months ago
Reviewers:
jennb
CC:
chromium-reviews, Dmitry Lomov (no reviews), jennb, Dmitry Titov, jianli, dcheng, Andrei
Visibility:
Public.

Description

Revert 120593 - Ensure the previously active browser window gets the focus after a browser window is closed on OSX. Also cleaned up extra orderOut: call since browser shutdown process has improved since that line was added. See crbug 23959 for history. This CL appears to cause regression issue 117621. BUG=112038, 117621 TEST=Manually open tabbed windows and panels and close them. Watch focus go back to last active window. Review URL: http://codereview.chromium.org/9310075 TBR=jennb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -41 lines) Patch
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +12 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_utils.h View 2 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_utils.mm View 3 chunks +1 line, -21 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.mm View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_window_controller_cocoa.mm View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Wez
8 years, 9 months ago (2012-03-12 22:23:33 UTC) #1
jennb
8 years, 9 months ago (2012-03-12 22:49:53 UTC) #2
LGTM

thanks!

Powered by Google App Engine
This is Rietveld 408576698