Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java

Issue 9692002: Step back and remove more getNode() invocations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java b/compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
index f629d022afbe2d8f6ffba9b450c57b7311c8d5b6..08f12d8e9cd360ea18c76b06f2c4ec30c10f8473 100644
--- a/compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
+++ b/compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
@@ -740,7 +740,7 @@ public class NegativeResolverTest extends CompilerTestCase {
errEx(ResolverErrorCode.DUPLICATE_TYPE_VARIABLE_WARNING, 4, 12, 2));
{
String message = errors.get(0).getMessage();
- assertEquals("Type variable 'BB' is hiding 'CLASS BB' at Test.dart::2:7", message);
+ assertEquals("Type variable 'BB' is hiding 'CLASS BB' at Test.dart:BB:2:7", message);
}
}
@@ -791,6 +791,18 @@ public class NegativeResolverTest extends CompilerTestCase {
}
/**
+ * We should ignore if setter parameter has same name and name of the setter method.
+ */
+ public void test_nameShadow_setter_sameParameterName() {
+ checkSourceErrors(
+ makeCode(
+ "// filler filler filler filler filler filler filler filler filler filler",
+ "class A {",
+ " set foo(foo) {}",
+ "}"));
+ }
+
+ /**
* Getter shadows field.
*/
public void test_nameShadow_field_getter() {

Powered by Google App Engine
This is Rietveld 408576698