Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java

Issue 9692002: Step back and remove more getNode() invocations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java b/compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java
index 3305dcee7b7379714d31a6e1579d3eff85d66b89..67de701798c514817cd5209802dd564dd6b86267 100644
--- a/compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java
+++ b/compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java
@@ -9,22 +9,26 @@ import com.google.dart.compiler.ast.DartIdentifier;
import com.google.dart.compiler.ast.DartMethodDefinition;
import com.google.dart.compiler.ast.DartNode;
import com.google.dart.compiler.ast.Modifiers;
+import com.google.dart.compiler.common.SourceInfo;
zundel 2012/03/12 20:05:57 If its just a couple of files, I don't mind but in
import com.google.dart.compiler.type.Type;
class FieldElementImplementation extends AbstractElement implements FieldElement {
private final EnclosingElement holder;
+ private final SourceInfo nameLocation;
private Modifiers modifiers;
private Type type;
private MethodElement getter;
private MethodElement setter;
FieldElementImplementation(DartNode node,
- String name,
- EnclosingElement holder,
- Modifiers modifiers) {
+ SourceInfo nameLocation,
+ String name,
+ EnclosingElement holder,
+ Modifiers modifiers) {
super(node, name);
this.holder = holder;
this.modifiers = modifiers;
+ this.nameLocation = nameLocation;
}
@Override
@@ -43,6 +47,11 @@ class FieldElementImplementation extends AbstractElement implements FieldElement
}
@Override
+ public SourceInfo getNameLocation() {
+ return nameLocation;
+ }
+
+ @Override
public EnclosingElement getEnclosingElement() {
return holder;
}
@@ -58,18 +67,23 @@ class FieldElementImplementation extends AbstractElement implements FieldElement
}
public static FieldElementImplementation fromNode(DartField node,
- EnclosingElement holder,
- Modifiers modifiers) {
- return new FieldElementImplementation(node, node.getName().getName(), holder, modifiers);
+ EnclosingElement holder,
+ Modifiers modifiers) {
+ return new FieldElementImplementation(node,
+ node.getName().getSourceInfo(),
+ node.getName().getName(),
+ holder,
+ modifiers);
}
public static FieldElementImplementation fromNode(DartMethodDefinition node,
- EnclosingElement holder,
- Modifiers modifiers) {
+ EnclosingElement holder,
+ Modifiers modifiers) {
return new FieldElementImplementation(node,
- ((DartIdentifier) node.getName()).getName(),
- holder,
- modifiers);
+ node.getName().getSourceInfo(),
+ ((DartIdentifier) node.getName()).getName(),
+ holder,
+ modifiers);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698