Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 9691044: In test_runner.dart, trim spaces from a special command before checking an assert. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 561a1fb92b8634d4a7daf03a4d7ec113700bd4ed..71d1335eb7083c2de912b67017f9f5050c816f32 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -90,8 +90,8 @@ class TestCase {
Expect.isTrue(specialCommand.contains('@'),
"special-command must contain a '@' char");
var specialCommandSplit = specialCommand.split('@');
- var prefix = specialCommandSplit[0];
- var suffix = specialCommandSplit[1];
+ var prefix = specialCommandSplit[0].trim();
+ var suffix = specialCommandSplit[1].trim();
List<Command> newCommands = [];
for (Command c in commands) {
var newExecutablePath;
@@ -113,7 +113,8 @@ class TestCase {
});
final newCommand = new Command(newExecutablePath, newArguments);
newCommands.add(newCommand);
- Expect.stringEquals('$prefix ${c.commandLine} $suffix',
+ // If there are extra spaces inside the prefix or suffix, this fails.
+ Expect.stringEquals('$prefix ${c.commandLine} $suffix'.trim(),
newCommand.commandLine);
}
commands = newCommands;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698