src/codegen.cc - Issue 9691042: Change --hydrogen-filter to allow specifying a negative filter for optimized functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codegen.cc

Issue 9691042: Change --hydrogen-filter to allow specifying a negative filter for optimized functions. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: addressed comments and fixed PrintCode Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/codegen.cc

===================================================================

--- src/codegen.cc (revision 10973)

+++ src/codegen.cc (working copy)

@@ -124,11 +124,9 @@

bool print_code = Isolate::Current()->bootstrapper()->IsActive()

? FLAG_print_builtin_code

: (FLAG_print_code || (info->IsOptimizing() && FLAG_print_opt_code));

- Vector<const char> filter = CStrVector(FLAG_hydrogen_filter);

- FunctionLiteral* function = info->function();

- bool match = filter.is_empty() || function->debug_name()->IsEqualTo(filter);

- if (print_code && match) {

+ if (print_code) {

Sven Panne 2012/03/14 09:12:07 If we remove the flag here, it should probably be

// Print the source code if available.

+ FunctionLiteral* function = info->function();

Handle<Script> script = info->script();

if (!script->IsUndefined() && !script->source()->IsUndefined()) {

PrintF("--- Raw source ---\n");

« no previous file with comments | « no previous file | src/compiler.cc » ('j') | no next file with comments »