Change --hydrogen-filter to allow specifying a negative filter for optimized functions.

src/compiler.cc

Index: src/compiler.cc
===================================================================
--- src/compiler.cc	(revision 10974)
+++ src/compiler.cc	(working copy)
@@ -244,12 +244,16 @@
   }
 
   // Take --hydrogen-filter into account.
-  Vector<const char> filter = CStrVector(FLAG_hydrogen_filter);
   Handle<String> name = info->function()->debug_name();
-  bool match = filter.is_empty() || name->IsEqualTo(filter);
-  if (!match) {
-    info->SetCode(code);
-    return true;
+  if (*FLAG_hydrogen_filter) {

[Sven Panne, 2012/03/14 07:35:36]

If this is allowed, I'll immediately start writing 'if (ptr) ...' for ptr being
an expression with a pointer type (something I really like, but which is
forbidden under Google law, I think). :-)

[fschneider, 2012/03/14 08:34:59]

I don't know about that, but I can compare it to \0 instead.

+    Vector<const char> filter = CStrVector(FLAG_hydrogen_filter);
+    ASSERT(!filter.is_empty());

[Sven Panne, 2012/03/14 07:35:36]

I don't think we need this assertion when the corresponding test is 2 lines
above.

[fschneider, 2012/03/14 08:34:59]

Done.

+    if ((filter[0] == '-'
+         && name->IsEqualTo(filter.SubVector(1, filter.length())))
+        || (filter[0] != '-' && !name->IsEqualTo(filter))) {
+      info->SetCode(code);
+      return true;
+    }
   }
 
   // Recompile the unoptimized version of the code if the current version