Issue 9690004: Prepare push to trunk. Now working on version 3.9.18.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9690004: Prepare push to trunk. Now working on version 3.9.18. (Closed)

Created:
8 years, 9 months ago by Sven Panne

Modified:
8 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prepare push to trunk. Now working on version 3.9.18. R=jkummerow@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10999

Patch Set 1 #

Total comments: 3

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	ChangeLog	View		1 chunk	+12 lines, -0 lines	3 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 9 months ago (2012-03-12 08:12:31 UTC) #2

LGTM with comments.

https://chromiumcodereview.appspot.com/9690004/diff/1/ChangeLog
File ChangeLog (right):

https://chromiumcodereview.appspot.com/9690004/diff/1/ChangeLog#newcode4
ChangeLog:4: (Chromium issue http://code.google.com/p/v8/issues/detail?id=1996)
Actually, its a V8 issue :-)
"(issue 1996)" would nail it.

https://chromiumcodereview.appspot.com/9690004/diff/1/ChangeLog#newcode5
ChangeLog:5: (Patch by rodolph.perfetta@gmail.com)
Don't need the "patch by" line

https://chromiumcodereview.appspot.com/9690004/diff/1/ChangeLog#newcode8
ChangeLog:8: (vegorov@chromium.org)
Don't need this line either.

Expand Messages | Collapse Messages