Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 9689075: Move some resources to a proper location. (Closed)

Created:
8 years, 9 months ago by Scott Byer
Modified:
8 years, 9 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Move some resources to a proper location. BUG=117587 TEST=build chrome, make sure cloud print from incognito window brings up a proper login dialog Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126691

Patch Set 1 : Move files. #

Patch Set 2 : Separated icon addition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -408 lines) Patch
M chrome/browser/browser_resources.grd View 1 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/browser/printing/cloud_print/resources/cell_phone.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/printing/cloud_print/resources/cloud_print_setup_done.css View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/printing/cloud_print/resources/cloud_print_setup_done.html View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/printing/cloud_print/resources/cloud_print_setup_done.js View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/printing/cloud_print/resources/cloud_print_setup_flow.html View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/printing/cloud_print/resources/cloud_print_setup_flow.js View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/printing/cloud_print/resources/cloud_print_setup_login.css View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/printing/cloud_print/resources/cloud_print_setup_login.html View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/printing/cloud_print/resources/cloud_print_setup_login.js View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/printing/cloud_print/resources/cloud_printer.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/printing/cloud_print/resources/sharing.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/cloud_print/cloud_print_setup_done.css View 1 chunk +50 lines, -44 lines 0 comments Download
A + chrome/browser/resources/cloud_print/cloud_print_setup_done.html View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/cloud_print/cloud_print_setup_done.js View 1 chunk +24 lines, -24 lines 0 comments Download
A + chrome/browser/resources/cloud_print/cloud_print_setup_flow.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/cloud_print/cloud_print_setup_flow.js View 1 chunk +47 lines, -47 lines 0 comments Download
A + chrome/browser/resources/cloud_print/cloud_print_setup_login.css View 1 chunk +6 lines, -0 lines 0 comments Download
A + chrome/browser/resources/cloud_print/cloud_print_setup_login.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/cloud_print/cloud_print_setup_login.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Scott Byer
8 years, 9 months ago (2012-03-13 19:29:37 UTC) #1
James Hawkins
LGTM. Thanks for doing this!
8 years, 9 months ago (2012-03-13 19:31:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottbyer@chromium.org/9689075/2024
8 years, 9 months ago (2012-03-13 19:36:54 UTC) #3
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary filesare still unsupported at ...
8 years, 9 months ago (2012-03-13 19:36:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottbyer@chromium.org/9689075/1004
8 years, 9 months ago (2012-03-14 15:40:51 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-14 15:40:57 UTC) #6
Can't apply patch for file
chrome/browser/resources/cloud_print/cloud_print_setup_done.css.
While running patch -p1 --forward --force;
patching file chrome/browser/resources/cloud_print/cloud_print_setup_done.css
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/resources/cloud_print/cloud_print_setup_done.css.rej

Powered by Google App Engine
This is Rietveld 408576698