Issue 9689071: Implement regular expression support for split and replace{First,All}.

Issue 9689071: Implement regular expression support for split and replace{First,All}. (Closed)

Created:
8 years, 9 months ago by cshapiro

Modified:
8 years, 9 months ago

Reviewers:
siva, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement regular expression support for split and replace{First,All}. BUG=429 Committed: https://code.google.com/p/dart/source/detail?r=5491

Patch Set 3 : update corelib.stat comment for StringSplitRegExpTest skip #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -16 lines)			Patch
M	runtime/lib/string.dart	View	1	2 chunks	+30 lines, -11 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
M	tests/corelib/corelib.status	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comments. -Ivan https://chromiumcodereview.appspot.com/9689071/diff/2001/runtime/lib/string.dart File runtime/lib/string.dart (right): https://chromiumcodereview.appspot.com/9689071/diff/2001/runtime/lib/string.dart#newcode211 runtime/lib/string.dart:211: } The assumption here is ...

8 years, 9 months ago (2012-03-14 05:05:37 UTC) #2

cshapiro

8 years, 9 months ago (2012-03-14 20:17:59 UTC) #3

https://chromiumcodereview.appspot.com/9689071/diff/2001/runtime/lib/string.dart
File runtime/lib/string.dart (right):

https://chromiumcodereview.appspot.com/9689071/diff/2001/runtime/lib/string.d...
runtime/lib/string.dart:211: }
Yes, I am perpetuating the assumption.  It is my belief that the real fix is to
correct allMatches so the implementation of replaceFirst and replaceAll can be
defined in terms of it.

https://chromiumcodereview.appspot.com/9689071/diff/2001/runtime/lib/string.d...
runtime/lib/string.dart:231: String from = pattern;
Agreed.

https://chromiumcodereview.appspot.com/9689071/diff/2001/tests/corelib/coreli...
File tests/corelib/corelib.status (right):

https://chromiumcodereview.appspot.com/9689071/diff/2001/tests/corelib/coreli...
tests/corelib/corelib.status:7: StringSplitRegExpTest: Skip    # Issue 429
Correct.  I was not going to close 429 until I got around to fixing allMatches. 
Would you prefer that I open another bug for that?  I am happy to do this either
way.

Expand Messages | Collapse Messages