Library privacy.

dart/frog/leg/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   SsaCodeGeneratorTask(Compiler compiler) : super(compiler);
   String get name() => 'SSA code generator';
 
   String generate(WorkItem work, HGraph graph) {
     return measure(() {
@@ skipping 90 matching lines @@
   HGraph currentGraph;
   HBasicBlock currentBlock;
 
   // Records a block-information that is being handled specially.
   // Used to break bad recursion.
   HLabeledBlockInformation currentBlockInformation;
   // The subgraph is used to delimit traversal for some constructions, e.g.,
   // if branches.
   SubGraph subGraph;
 
+  LibraryElement get currentLibrary() => work.element.getLibrary();
+
   SsaCodeGenerator(this.compiler,
                    this.work,
                    this.buffer,
                    this.parameters,
                    this.parameterNames)
     : names = new Map<int, String>(),
       prefixes = new Map<String, int>() {
     for (final name in parameterNames.getValues()) {
       prefixes[name] = 0;
     }
@@ skipping 393 matching lines @@
     }
   }
 
   visitInvokeDynamicMethod(HInvokeDynamicMethod node) {
     beginExpression(JSPrecedence.CALL_PRECEDENCE);
     use(node.receiver, JSPrecedence.MEMBER_PRECEDENCE);
     buffer.add('.');
     // Avoid adding the generative constructor name to the list of
     // seen selectors.
     if (node.inputs[0] is HForeignNew) {
+      HForeignNew foreignNew = node.inputs[0];
       // Remove 'this' from the number of arguments.
       int argumentCount = node.inputs.length - 1;
-      buffer.add(compiler.namer.instanceMethodName(node.name, argumentCount));
+      if (node.name.isPrivate()) {

[floitsch, 2012/03/13 13:28:56]

static elements don't need to be mangled wrt privacy.

[ahe, 2012/03/17 22:19:44]

Done.

+        buffer.add(node.name);
+      } else {
+        buffer.add(compiler.namer.instanceMethodName(currentLibrary,
+                                                     node.name, argumentCount));
+      }
       visitArguments(node.inputs);
     } else {
       buffer.add(compiler.namer.instanceMethodInvocationName(
-          node.name, node.selector));
+          currentLibrary, node.name, node.selector));
       visitArguments(node.inputs);
       compiler.registerDynamicInvocation(node.name, node.selector);
     }
     endExpression(JSPrecedence.CALL_PRECEDENCE);
   }
 
   visitInvokeDynamicSetter(HInvokeDynamicSetter node) {
     beginExpression(JSPrecedence.CALL_PRECEDENCE);
     use(node.receiver, JSPrecedence.MEMBER_PRECEDENCE);
     buffer.add('.');
-    buffer.add(compiler.namer.setterName(node.name));
+    buffer.add(compiler.namer.setterName(currentLibrary, node.name));
     visitArguments(node.inputs);
     compiler.registerDynamicSetter(node.name);
     endExpression(JSPrecedence.CALL_PRECEDENCE);
   }
 
   visitInvokeDynamicGetter(HInvokeDynamicGetter node) {
     beginExpression(JSPrecedence.CALL_PRECEDENCE);
     use(node.receiver, JSPrecedence.MEMBER_PRECEDENCE);
     buffer.add('.');
-    buffer.add(compiler.namer.getterName(node.name));
+    buffer.add(compiler.namer.getterName(currentLibrary, node.name));
     visitArguments(node.inputs);
     compiler.registerDynamicGetter(node.name);
     endExpression(JSPrecedence.CALL_PRECEDENCE);
   }
 
   visitInvokeClosure(HInvokeClosure node) {
     beginExpression(JSPrecedence.CALL_PRECEDENCE);
     use(node.receiver, JSPrecedence.MEMBER_PRECEDENCE);
     buffer.add('.');
     buffer.add(compiler.namer.closureInvocationName(node.selector));
@@ skipping 12 matching lines @@
   }
 
   visitInvokeSuper(HInvokeSuper node) {
     beginExpression(JSPrecedence.CALL_PRECEDENCE);
     Element superMethod = node.element;
     Element superClass = superMethod.enclosingElement;
     // Remove the element and 'this'.
     int argumentCount = node.inputs.length - 2;
     String className = compiler.namer.isolatePropertyAccess(superClass);
     String methodName = compiler.namer.instanceMethodName(
-        superMethod.name, argumentCount);
+        currentLibrary, superMethod.name, argumentCount);
     buffer.add('$className.prototype.$methodName.call');
     visitArguments(node.inputs);
     endExpression(JSPrecedence.CALL_PRECEDENCE);
     compiler.registerStaticUse(superMethod);
   }
 
   visitFieldGet(HFieldGet node) {
     String name = JsNames.getValid(node.element.name.slowToString());
     if (node.receiver !== null) {
       beginExpression(JSPrecedence.MEMBER_PRECEDENCE);
@@ skipping 832 matching lines @@
       startBailoutSwitch();
     }
   }
 
   void endElse(HIf node) {
     if (node.elseBlock.hasBailouts()) {
       endBailoutSwitch();
     }
   }
 }