Library privacy.

dart/frog/leg/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Interceptors {
   Compiler compiler;
   Interceptors(Compiler this.compiler);
 
   SourceString mapOperatorToMethodName(Operator op) {
     String name = op.source.stringValue;
@@ skipping 693 matching lines @@
   // block is closed.
   HBasicBlock lastOpenedBlock;
 
   // Linked list of active break-handlers. Will be removed in the order
   // they are added.
   BreakHandler currentBreakHandler = const NullBreakHandler();
   // The break handler to use for an upcoming loop statement (temporarily set
   // if a labeled statement is labeling a loop).
   BreakHandler loopBreakHandler = null;
 
+  LibraryElement get currentLibrary() => work.element.getLibrary();
+
   SsaBuilder(Compiler compiler, WorkItem work)
     : this.compiler = compiler,
       this.work = work,
       interceptors = compiler.builder.interceptors,
       methodInterceptionEnabled = true,
       elements = work.resolutionTree,
       graph = new HGraph(),
       stack = new List<HInstruction>(),
       breakTargets = new Map<StatementElement, BreakHandler>() {
     localsHandler = new LocalsHandler(this);
@@ skipping 165 matching lines @@
       // TODO(floitsch): find better way to detect that constructor body is
       // empty.
       if (constructor is SynthesizedConstructorElement) continue;
       ConstructorBodyElement body = getConstructorBody(classElement,
                                                        constructor);
       List bodyCallInputs = <HInstruction>[];
       bodyCallInputs.add(newObject);
       body.functionParameters.forEachParameter((parameter) {
         bodyCallInputs.add(localsHandler.readLocal(parameter));
       });
-      SourceString methodName = body.name;
+      SourceString methodName;
+      if (body.name.isPrivate()) {

[ngeoffray, 2012/03/13 12:47:11]

Why do you need to do this and avoid it in codegen?

[floitsch, 2012/03/13 13:28:56]

I'm don't think this is necessary at all.
Constructor bodies are statically resolved.

[ahe, 2012/03/17 22:19:44]

I'm not sure how to invoke a statically resolved method on this. I have changed
how these names are used and generated.

+        methodName = new SourceString(compiler.namer.instanceMethodName(
+            constructor.getLibrary(), body.name, bodyCallInputs.length - 1));
+      } else {
+        methodName = body.name;
+      }
       add(new HInvokeDynamicMethod(null, methodName, bodyCallInputs));
     }
     close(new HReturn(newObject)).addSuccessor(graph.exit);
     return closeFunction();
   }
 
   void openFunction(FunctionElement functionElement,
                     FunctionExpression node) {
     HBasicBlock block = graph.addNewBlock();
     open(graph.entry);
@@ skipping 844 matching lines @@
         visit(expression);
         enableMethodInterception();
         break;
       case "JS_HAS_EQUALS":
         List<HInstruction> inputs = <HInstruction>[];
         if (!node.arguments.tail.isEmpty()) {
           compiler.cancel('More than one expression in JS_HAS_EQUALS()');
         }
         addGenericSendArgumentsToList(node.arguments, inputs);
         String name = compiler.namer.instanceMethodName(
-            Namer.OPERATOR_EQUALS, 1);
+            currentLibrary, Namer.OPERATOR_EQUALS, 1);
         push(new HForeign(new DartString.literal('\$0.$name'),
                           const LiteralDartString('bool'),
                           inputs));
         break;
       case "native":
         native.handleSsaNative(this, node);
         break;
       default:
         throw "Unknown foreign: ${node.selector}";
     }
@@ skipping 718 matching lines @@
     buildBody() {
       // TODO(lrn): Make sure to take continue into account.
       visit(body);
       if (isAborted()) {
         compiler.reportWarning(body, "aborting loop body");
       }
     }
     handleIf(buildBody, null);
   }
 }