Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 9689043: Roll Skia DEPS to 3365 (Closed)

Created:
8 years, 9 months ago by epoger
Modified:
8 years, 9 months ago
Reviewers:
reed1
CC:
chromium-reviews, skia-dev_google.com, reed1
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
control group is https://chromiumcodereview.appspot.com/9696015 I plan to compare this roll's results with these other ones: ...
8 years, 9 months ago (2012-03-13 00:07:18 UTC) #1
reed1
lgtm
8 years, 9 months ago (2012-03-13 12:40:50 UTC) #2
epoger
I'm examining the results of this deps roll now... I will add a summary of ...
8 years, 9 months ago (2012-03-13 13:13:04 UTC) #3
Tom Hudson
scrollbar-double-click is clearly flake. terminate-during-sync-operation is PASS CRASH, so no surprise. I am a bit ...
8 years, 9 months ago (2012-03-13 13:20:31 UTC) #4
epoger
8 years, 9 months ago (2012-03-13 13:21:46 UTC) #5
The results look reasonably good on Linux and Mac (summary below); as usual, the
Windows trybots were fairly useless. :-(

I'm going to commit this.

linux : 1 new sync_unit_test failure, but looks like a flake
linux_chromeos : green
linux_gpu : green
linux_layout : green
linux_layout_rel : 1 new webkit_test failure, but it's probably a flake
  fast/forms/form-associated-element-removal.html = MISSING
linux_shared : green

mac : green
mac_gpu : green
mac_layout : 3 new webkit_test failures, but they look like flakes
  transitions/transition-end-event-nested.html = TEXT
  fast/files/workers/worker-read-file-async.html = CRASH
  http/tests/workers/terminate-during-sync-operation.html = TIMEOUT
mac_layout_rel : 1 new webkit_test failure, looks like a flake
  fast/events/invalid-004.html = CRASH

win : no new failures
win_gpu : green
win_layout : timed out in update step, just like control group
win_layout_rel : timed out in update step

Powered by Google App Engine
This is Rietveld 408576698