Derive DomStorageTaskRunner from base::TaskRunner now that it exists.

Derive DomStorageTaskRunner from base::TaskRunner now that it exists.

BUG=106763
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126500

[michaeln, 2012-03-12 21:44:29]

ptal

[benm (inactive), 2012-03-13 11:09:56]

lgtm

http://codereview.chromium.org/9689033/diff/4001/webkit/dom_storage/dom_stora...
File webkit/dom_storage/dom_storage_task_runner.h (right):

http://codereview.chromium.org/9689033/diff/4001/webkit/dom_storage/dom_stora...
webkit/dom_storage/dom_storage_task_runner.h:38: // by calling the virtual
PostDelayedTask(..., TimeDelta) variant.
Why not just use this delay_ms variant and lose the TimeDelta one?

[michaeln, 2012-03-13 18:52:13]

tedv's been gradually replaying int_value_ms usage with TimeDelta throughout the
project. I was surprised to see the _ms usage in this relatively new class. We
shouldn't use the _ms variant in the dom_storage library.

> Why not just use this delay_ms variant and lose the TimeDelta one?

[Ben Murdoch, 2012-03-13 18:53:46]

Cool, thanks for clarifying!

On 13 March 2012 18:52, <michaeln@chromium.org> wrote:

> tedv's been gradually replaying int_value_ms usage with TimeDelta
> throughout the
> project. I was surprised to see the _ms usage in this relatively new
> class. We
> shouldn't use the _ms variant in the dom_storage library.
>
>
>  Why not just use this delay_ms variant and lose the TimeDelta one?
>>
>
>
>
>
http://codereview.chromium.**org/9689033/<http://codereview.chromium.org/9689...
>



-- 
Google UK Limited

Registered Office: Belgrave House, 76 Buckingham Palace Road, London SW1W
9TQ
Registered in England Number: 3977902