Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 9689023: Tiny fix in Dart_CreateIsolate to allow errors to print correctly. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
===================================================================
--- runtime/vm/dart_api_impl.cc (revision 5192)
+++ runtime/vm/dart_api_impl.cc (working copy)
@@ -585,17 +585,18 @@
char** error) {
Isolate* isolate = Dart::CreateIsolate(name_prefix);
assert(isolate != NULL);
- DARTSCOPE_NOCHECKS(isolate);
- const Error& error_obj =
- Error::Handle(Dart::InitializeIsolate(snapshot, callback_data));
- if (error_obj.IsNull()) {
- START_TIMER(time_total_runtime);
- return reinterpret_cast<Dart_Isolate>(isolate);
- } else {
+ {
+ DARTSCOPE_NOCHECKS(isolate);
+ const Error& error_obj =
+ Error::Handle(Dart::InitializeIsolate(snapshot, callback_data));
+ if (error_obj.IsNull()) {
+ START_TIMER(time_total_runtime);
+ return reinterpret_cast<Dart_Isolate>(isolate);
+ }
*error = strdup(error_obj.ToErrorCString());
- Dart::ShutdownIsolate();
- return reinterpret_cast<Dart_Isolate>(NULL);
}
+ Dart::ShutdownIsolate();
+ return reinterpret_cast<Dart_Isolate>(NULL);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698