Issue 9688019: Add a Content API around BrowserURLHandler.

Issue 9688019: Add a Content API around BrowserURLHandler. (Closed)

Created:
8 years, 9 months ago by jam

Modified:
8 years, 9 months ago

Reviewers:
Jói

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add a Content API around BrowserURLHandler. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126180

Patch Set 3 : fix gypis #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -358 lines)			Patch
M	chrome/browser/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chrome_content_browser_client.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser_navigator.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
D	content/browser/browser_url_handler.h	View		1 chunk	+0 lines, -77 lines	0 comments	Download
D	content/browser/browser_url_handler.cc	View		1 chunk	+0 lines, -128 lines	0 comments	Download
A +	content/browser/browser_url_handler_impl.h	View	1	3 chunks	+19 lines, -41 lines	0 comments	Download
A +	content/browser/browser_url_handler_impl.cc	View		5 chunks	+16 lines, -9 lines	0 comments	Download
A +	content/browser/browser_url_handler_impl_unittest.cc	View		3 chunks	+8 lines, -8 lines	0 comments	Download
D	content/browser/browser_url_handler_unittest.cc	View		1 chunk	+0 lines, -78 lines	0 comments	Download
M	content/browser/renderer_host/test_render_view_host.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/tab_contents/navigation_controller_impl.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/tab_contents/render_view_host_manager_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/tab_contents/test_tab_contents.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/content_browser.gypi	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	content/content_tests.gypi	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A	content/public/browser/browser_url_handler.h	View		1 chunk	+57 lines, -0 lines	0 comments	Download
M	content/public/browser/content_browser_client.h	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jói

LGTM once .gypi issues are addressed. Cheers, Jói http://codereview.chromium.org/9688019/diff/5001/content/content_browser.gypi File content/content_browser.gypi (right): http://codereview.chromium.org/9688019/diff/5001/content/content_browser.gypi#newcode185 content/content_browser.gypi:185: 'browser/browser_url_handler_impl.cc', ...

8 years, 9 months ago (2012-03-12 17:39:14 UTC) #2

jam

8 years, 9 months ago (2012-03-12 17:44:41 UTC) #3

thanks, done

(because reloading slns is so slow, I usually modify my vcproj in VS instead of
reloading so it worked locally, and then i just depend on trybots to make sure
my changes worked!)

http://codereview.chromium.org/9688019/diff/5001/content/content_browser.gypi
File content/content_browser.gypi (right):

http://codereview.chromium.org/9688019/diff/5001/content/content_browser.gypi...
content/content_browser.gypi:185: 'browser/browser_url_handler_impl.cc',
On 2012/03/12 17:39:14, Jói wrote:
> the content/public header should be added to the list in the appropriate place

Done.

http://codereview.chromium.org/9688019/diff/5001/content/content_tests.gypi
File content/content_tests.gypi (right):

http://codereview.chromium.org/9688019/diff/5001/content/content_tests.gypi#n...
content/content_tests.gypi:197: 'browser/browser_url_handler.cc',
On 2012/03/12 17:39:14, Jói wrote:
> this looks wrong, should have been _impl_unittest.cc ?

Done.

Expand Messages | Collapse Messages